Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sa 3118 get jc system app #463

Merged
merged 119 commits into from
Feb 7, 2023
Merged

Sa 3118 get jc system app #463

merged 119 commits into from
Feb 7, 2023

Conversation

kmaranionjc
Copy link
Contributor

@kmaranionjc kmaranionjc commented Feb 6, 2023 •
edited by jira bot
Loading

Issues

  • SA-3118 - SA-3138_Get-JCSystemApp

What does this solve?

Merge Get-JCSystemApp to master and PSGallery

Is there anything particularly tricky?

n/a

How should this be tested?

Verify Get-JCSystemApp parameters are working properly

kmaranionjc and others added 30 commits January 12, 2023 08:21
@kmaranionjc
Init commit Get-JCSystemApp
9b48e5a
@kmaranionjc
cleanup
cfc6384
@kmaranionjc
softwarename
abb6739
@jworkmanjc
first pass at Get-JCsystemApp tests
63e8258
@kmaranionjc
Added search by OS
a9047ab
@kmaranionjc
Added $search parameter
252a5f4
@kmaranionjc
version
1a42c14
@jworkmanjc
ssh key change r/w
fd87030
@jworkmanjc
support ssh key
2a7d3e9
@jworkmanjc
ssh key
7f3cf2e
@jworkmanjc
ssh key
0893c80
@jworkmanjc
ssh key
6cbbb2e
Updating PowerShell Module;[skip ci]
5c61716
@kmaranionjc
ModuleChangelog and docs
80b000a
Updating PowerShell Module;[skip ci]
04e66dd
Updating PowerShell Module;[skip ci]
6aaf43c
@kmaranionjc
search
c3c01da
Updating PowerShell Module;[skip ci]
948fab2
@kmaranionjc
fixed search
ede019b
Updating PowerShell Module;[skip ci]
354309a
@kmaranionjc
fix object error
962821b
@kmaranionjc
Merge branch 'SA-3067-Get-JCSystemApp' of https://github.com/TheJumpC…
cfc9404 
…loud/support into SA-3067-Get-JCSystemApp
Updating PowerShell Module;[skip ci]
85056b2
Updating PowerShell Module;[skip ci]
33c6671
@jworkmanjc
additional search + compatibility tests
0d66650
@jworkmanjc
export to csv tests
0b2937a
@kmaranionjc
added tests, cleanup
2229128
@kmaranionjc
cleanup, added tests
b5c504b
@kmaranionjc
Merge branch 'SA-3067-Get-JCSystemApp' of https://github.com/TheJumpC…
a76c403 
…loud/support into SA-3067-Get-JCSystemApp
Updating PowerShell Module;[skip ci]
efc864b
TheJumpCloud and others added 13 commits February 3, 2023 21:32
Updating PowerShell Module;[skip ci]
123c7a8
@kmaranionjc @jworkmanjc
Update PowerShell/JumpCloud Module/Public/Systems/Get-JCSystemApp.ps1…
a5d5862 
… [skip ci]

Co-authored-by: Joe Workman <54448601+jworkmanjc@users.noreply.github.com>
@kmaranionjc
pr changes
8398d32
Updating PowerShell Module;[skip ci]
b00eff0
@kmaranionjc
updated the tests
e0f88b6
Updating PowerShell Module;[skip ci]
5afb1ec
@kmaranionjc
fixed get-jcsdksystem
782faca
@kmaranionjc
Merge branch 'SA-3139-replace_iwr_with_sdk' of https://github.com/The…
a338b0f 
…JumpCloud/support into SA-3139-replace_iwr_with_sdk
Updating PowerShell Module;[skip ci]
912cabd
@kmaranionjc
fix tests
c13286c
@kmaranionjc
Merge branch 'SA-3139-replace_iwr_with_sdk' of https://github.com/The…
2353138 
…JumpCloud/support into SA-3139-replace_iwr_with_sdk
Updating PowerShell Module;[skip ci]
7267db0
@kmaranionjc
Merge pull request #462 from TheJumpCloud/SA-3139-replace_iwr_with_sdk
90ed85e 
Sa 3139 replace iwr with sdk
@kmaranionjc kmaranionjc self-assigned this Feb 6, 2023
jworkmanjc
jworkmanjc approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested just now & reviewed the documentation/ examples this morning. Looks good. Let's go!

gweinjc
gweinjc requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog wording is a bit confusing

@kmaranionjc kmaranionjc merged commit 5cdab54 into master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweinjc gweinjc gweinjc requested changes

@jworkmanjc jworkmanjc jworkmanjc approved these changes

Assignees

@kmaranionjc kmaranionjc

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmaranionjc @jworkmanjc @gweinjc