-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing Page: capitalize Google #29308
Landing Page: capitalize Google #29308
Comments
Thank you for making this issue @oshkosher. It should definitely be capitalized. We have it capitalized almost everywhere else in the curriculum, whether it's used as a noun or a verb. In fact, I was wondering if you'd be okay with capitalizing it in the other places I've found?
Since you checked the box saying you'd like to work on this, I'll assign you. Feel free to include changes for the above two lessons in your PR as well. Let me know if you have any questions. |
Hi @JoshDevHub, I see that the issue regarding capitalization is still open. I'd like to take care of this and capitalize it in the other places mentioned, including the assignment sections of the grid properties and positioning grid elements lessons. Please let me know if that works for you! |
@swayamsharma16 Thank you for volunteering. I'll give the original author another week or two to put in a PR, but if they end up not being able to work on it, then I'll assign it to you. |
Capitalize uses of "google", without modifying URLs or code. There is also one one file in the theodinproject repo that should be fixed.
I've got a fix for this that touches six files. The PR template says the PR name must include the location of the change. Should I just say "multiple-files: capitalize Google"? |
@oshkosher You can say something like Nice job finding other places to fix it! I will say to avoid fixing anything that's in |
Yep, that's what I figured; I filtered those out. |
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because Capitalize Googled to recognize Google as a trademarked term. ## This PR - "Asking questions that can be easily googled" -> "Asking questions that can be easily Googled" ## Issue Closes TheOdinProject/curriculum#29308 ## Additional Information ## Pull Request Requirements - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [x] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [x] If applicable, this PR includes new or updated automated tests Co-authored-by: Ed K <ed.karrels+nano+ubuntu@gmail.com>
Checks
Describe your suggestion
Google is referenced (as a noun) a few times on this page, but is not capitalized. Just as credit should be given to copyright owners when their images are used, Google is a trademark and should be capitalized.
As for whether it should be capitalized when used as a verb, formal sources says yes (https://www.chicagomanualofstyle.org/qanda/data/faq/topics/RegisteredTrademarks/faq0001.html) but informal sources say no (https://grammarist.com/spelling/google-vs-google/).
Path
Foundations
Lesson Url
https://www.theodinproject.com/lessons/foundations-landing-page
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: