Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Curriculum: Capitalize Google (#29308) #29361

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

oshkosher
Copy link
Contributor

Capitalize uses of "google", without modifying URLs or code. There is also one one file in the theodinproject repo that should be fixed.

Because

The word Google appears in lowercase in places, sometimes as a noun, sometimes as a verb, and sometimes as an adjective ("googleable"). It is a trademark, and should thus be capitalized.

This PR

  • foundations/html_css/flexbox/project-landing-page.md
    • "use google" -> "use Google"
    • "google css rounded corners" -> "Google css rounded corners"
  • foundations/installations/installations.md
    • "You can google" -> "You can Google"
  • foundations/introduction/join_the_odin_community.md
    • "googleable questions" -> "Googleable questions"
  • intermediate_html_css/grid/advanced_grid_properties.md
    • "use google" -> "use Google"
  • intermediate_html_css/grid/positioning_grid_elements.md
    • "use google" -> "use Google"
  • ruby_on_rails/apis/project_kittens_api.md
    • "google XYZ API docs" -> "Google XYZ API docs"

Issue

Closes #29308

Additional Information

There is an additional use of lowercase "google" in the "theodinproject" repo in
app/views/guides/community/rules.html.erb

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Capitalize uses of "google", without modifying URLs or code.
There is also one one file in the theodinproject repo that
should be fixed.
@github-actions github-actions bot added Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course Content: Ruby on Rails Involves the Ruby on Rails course Content: Foundations Involves the Foundations content labels Jan 29, 2025
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Feel free to put a PR (no need to make an issue first) that capitalizes it on the rules page on the main site repo.

@JoshDevHub JoshDevHub merged commit 2bdfb18 into TheOdinProject:main Jan 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing Page: capitalize Google
2 participants