Support variable length dimension label reads #1802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #29317: Dimension label Python API String read support. |
shaunrd0
force-pushed
the
smr/sc-29317/var-size-dim-labels
branch
2 times, most recently
from
09ee91d
to
7ac3741
Compare
shaunrd0
force-pushed
the
smr/sc-29317/var-size-dim-labels
branch
from
fac1cf0
to
b878db8
Compare
+ TODO: Revert this commit
+ Bug was in core Query::result_buffer_elements_nullable
This reverts commit 32df5f3.
shaunrd0
force-pushed
the
smr/sc-29317/var-size-dim-labels
branch
from
9dd3642
to
bb10cf7
Compare
ihnorton
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for variable length dimension label reads. This change requires TileDB-Inc/TileDB#4142 to add dimension label support for result_buffer_elements_nullable to size read offset buffers. The experimental dimension label variant of this function is defined as
QueryExperimental::result_buffer_elements_nullable_labelsand used in this PR to determine the number of offsets read by the var-size dimension label query.