Release 0.22 against TileDB 2.16.0 #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also use manylinux2014 image with required headers for vcpkg build
ihnorton
force-pushed
the
release-build-0.22
branch
3 times, most recently
from
58a4acc
to
02293f5
Compare
```
2023-07-16T21:39:48.3753245Z In file included from tiledb/core.cc:39:
2023-07-16T21:39:48.3764304Z tiledb/query_condition.cc: In member function ‘pybind11::capsule tiledbpy::PyQueryCondition::__capsule__()’:
2023-07-16T21:39:48.3767740Z tiledb/query_condition.cc:61:69: error: call of overloaded ‘capsule(std::shared_ptr<tiledb::QueryCondition>*, const char [3], std::nullptr_t)’ is ambiguous
2023-07-16T21:39:48.3768212Z 61 | py::capsule __capsule__() { return py::capsule(&qc_, "qc", nullptr); }
```
- Also pin pybind11 in pyproject
- Also pin cython<3.0
Failed to raise KeyError, I believe due to uninitialized variables.
Adds support for variable length dimension label reads. This change requires TileDB-Inc/TileDB#4142 to add dimension label support for [result_buffer_elements_nullable](https://github.com/TileDB-Inc/TileDB-Py/blob/dev/tiledb/core.cc#L717) to size read offset buffers. The experimental dimension label variant of this function is defined as `QueryExperimental::result_buffer_elements_nullable_labels` and used in this PR to determine the number of offsets read by the var-size dimension label query.
ihnorton
force-pushed
the
release-build-0.22
branch
2 times, most recently
from
1b0af10
to
2265e08
Compare
ihnorton
force-pushed
the
release-build-0.22
branch
from
2265e08
to
6ad992f
Compare
Shelnutt2
approved these changes
Jul 17, 2023
|
🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheel check from this build: