-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build enhancement for Conda #722
Conversation
I tested this PR on my feedstock fork (commit, build)
I still think we should merge this PR since it unblocks this new feature for the osx-64 conda binary. However, we'll need to do some troubleshooting before the next r-tiledb-feedstock release in order to figure out which test(s) to skip on linux-aarch64. From comparing the R 4.2 and 4.3 logs, it appears the error occurs on the 20th test in |
I suspect the error is happening here. Any reason to suspect this code would be consistently problematic for R 4.3 (but not 4.2) and linux-aarch64 (but not linux-64)? Worst case I'll just add a patch to the conda recipe to skip on linux-aarch64 TileDB-R/inst/tinytest/test_fragmentinfo.R Lines 56 to 65 in e37db85
|
Two conversations here:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
As owner of this issue and PR I took the liberty of marking the very interesting and passionate (but not really relevant here) discussion of another build platform as off-topic. The current state (and primary puzzle) is that enabling Conda killed macOS. Bad trade-off. |
So we now have the CI Actions back to ✔️ but there may be remaining Conda questions. |
a33e587
to
d9a0019
Compare
Testing the latest change that uses the env var https://dev.azure.com/jdblischak/feedstock-builds/_build/results?buildId=863&view=results |
PR #710 (with SC 47400) brought in a small extension which included small Makevars (the Makefile snippet used by the R package) changes. As was seen in the subsequent release this was not fully Conda-compliant but additional tests helped determine a very small additional fix. A review by @jdblischak (who already tested this) would be nice but I cannot currently request one.