-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for r-base 4.4 and UCRT mingw toolchain #87
Rebuild for r-base 4.4 and UCRT mingw toolchain #87
Conversation
…nda-forge-pinning 2024.08.28.19.57.49
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I am confused. How did this get triggered now? R 4.4.0 came out ~ four months ago, and R 4.4.1 followed ~ 2 months ago. |
conda-forge lags behind the official R releases. First the new R release has to be packaged with the conda-forge toolchain. Then it has to migrate throughout the dependency network. The R 4.4 migration is almost finished: https://conda-forge.org/status/migration/?name=r-base44_and_m2w64-ucrt |
The osx-64 failure is with the new r-base 4.4:
|
This doesn't immediately explain why v4.4 and not v4.3 fails, but probably shouldn't be passing both |
@mfansler do you know how we can override the I ask because we have previously tried to set We already set r-tiledb-feedstock/recipe/conda_build_config.yaml Lines 1 to 2 in ae28f80
which results in r-tiledb-feedstock/.ci_support/osx_64_.yaml Lines 1 to 8 in ae28f80
Looking at our last successful osx-64 build for R 4.3 in main, this resulted in the macOS 10.14 SDK being downloaded and Note that we also have some non-standard wrapper scripts for the compiler on osx-64 in this repository: r-tiledb-feedstock/recipe/cxx_wrap.sh Lines 3 to 4 in ae28f80
I did some experiments in a branch on my fork. I tried updating the wrapper scripts to replace args="${@##-mmacosx-version-min=10.13*}"
$NN_CC_ORIG $args -mmacosx-version-min=10.14 I also tried not using the wrapper scripts at all. This similarly had zero effect. The R 4.3 job passed, and the R 4.4 failed with the same error. Furthermore, both continued to inject the double |
This is an oddly specific error to macOS only on R 4.4:
For some reason it's trying to load a shared library from a directory instead of a proper dylib. I'm not sure if that's because the dylib isn't being build or the wrong path is being passed to the loader. |
@danielnachun That is a very standard part of each and every R package build: to test whether the build is truly relocatable it runs it from the temporary directory, and if successful, moves it and tests it again. |
That test makes sense but the issue here is that this error (I should have formatted the code block better):
seems to imply that it's trying to use |
@jdblischak looks like it was captured in the CPPFLAGS = -D_FORTIFY_SOURCE=2 \
-isystem /Users/runner/miniforge3/conda-bld/r-base-split_1723488738748/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include \
-mmacosx-version-min=10.13 \
-mmacosx-version-min=10.13 \
-I/Users/runner/miniforge3/conda-bld/r-base-split_1723488738748/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/include I'm unsure if that should be the case, so I'll post an Issue. However, I won't have bandwidth today to look into it further. I think the question of whether this actually is the problem here hinges on whether |
I have an idea of what could be causing the problem with R 4.4.
So I think we need the extension |
@jdblischak That makes a lot of sense! I guess we just need to know how to set the file extension and then this will hopefully work? |
I am going to work on a patch for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR has been triggered in an effort to update r-base44_and_m2w64-ucrt.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10604935422 - please use this URL for debugging.