-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiledbsoma 1.8.0 pre-check #91
Conversation
[sc-41030] |
This pull request has been linked to Shortcut Story #41030: Update projects to TileDB 2.20. |
Currently failing with similar conda solver errors as we previously identified in #89 (comment) We are getting conda solver errors in multiple feedstocks, so there must be some systemic problem. I'm hoping that this commit merged earlier this morning (which migrates to libgoogle-cloud 2.21) will help ease the solver problems 🤞 |
@jdblischak are we waiting for some sort of propagation? 🤔 |
Yes, I'm hoping that maybe the new tiledb 2.20.1 binaries that were built against libgoogle-cloud 2.21 might help with the current solver issue. They were uploaded more than 2 hours ago, so should be available now https://anaconda.org/conda-forge/tiledb/files?version=2.20.1 (note that the build numbers are weird (two different sets with build number 1) because of all the merge commits we've done recently in tiledb-feedstock. Fortunately the migration to libgoogle-cloud 2.21 also changed the build hash, so new binaries were uploaded) |
Welp that didn't fix it. The latest failed CI run used the latest tiledb built against libgoogle-cloud 2.21
|
…nda-forge-pinning 2024.02.28.18.36.29
The solver error from the latest run was decently informative. We know it has to do with libabseil, libcurl, and libgoogle-cloud-storage
|
https://anaconda.org/conda-forge/google-cloud-cpp/files updated 4 days ago ... 🤔 |
Weird thing is 2.17 doesn't exist at all at https://anaconda.org/conda-forge/google-cloud-cpp/files ... 🤔 |
OK I may be mixing
🤔 |
[sc-42200] |
This pull request has been linked to Shortcut Story #42200: tiledbsoma 1.8.0. |
a2dd497
to
2812f82
Compare
recipe/meta.yaml
Outdated
@@ -90,6 +91,7 @@ outputs: | |||
- pyarrow <13.0 # [osx] | |||
- pyarrow # [not osx] | |||
- pyarrow-hotfix | |||
- libgoogle-cloud 2.12.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to be 2.21?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(actually, why are we pinning this at all?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not
See Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add some details here momentarily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.12 is absolutely and unequivocally needed for core 2.19 / tiledbsoma 1.7:
#93 (comment)
I'm confirming now for this PR 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(actually, why are we pinning this at all?)
It's a hacky workaround we are applying to unblock tiledbsoma. Originally discovered in #89, this solver error came out of nowhere. I suspect it has to do with the recent conda-forge switch from google-cloud-cpp to libgoogle-cloud, but I've been too busy with the libcurl 7 stuff to figure out exactly what is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, carry on - thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR 2.12 doesn't work although it did for #93:
https://gist.github.com/johnkerl/7812fb057db778d8bfb17b424dec6ead
Trying 2.17 locally ... 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Based on the error, I think libgoogle-cloud 2.17 should work
Could not solve for environment specs
The following packages are incompatible
├─ libgoogle-cloud ==2.17.0 h31df0ca_2 is requested and can be installed;
└─ libtiledbsoma ==1.8.0 hd763302_0 is not installable because it requires
└─ libgoogle-cloud >=2.12.0,<2.13.0a0 , which conflicts with any installable versions previously reported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libgoogle-cloud 2.17 fixed the conda solver error. However, only the linux-64 build is green
The osx-64 build is now failing because the r-tiledbsoma compilation is failing with a bunch of macOS SDK errors. Maybe we need to adjust tiledbsoma-feedstock/recipe/conda_build_config.yaml Lines 1 to 4 in 6663e51
Here is the final part of the errors:
In the osx-arm64 build, r-tiledbsoma compiles fine. The failure is due to tiledbsoma-py being unable to find libtiledbsoma.so in the conda env, and then failing to build it from source:
My guess is that this might be due to single-cell-data/TileDB-SOMA#1937 since it updated how tiledbsoma-py interacts with an existing libtiledbsoma.so |
From the nightly feedstock builds, the R compilation error on osx-64 started on Feb 12th. And the osx-arm64 builds started failing on Feb 16th, so I am more confident that it was caused by single-cell-data/TileDB-SOMA#1937, which was merged earlier that day in single-cell-data/TileDB-SOMA@f4999d8 |
@jdblischak FYI I've confirmed this locally (for linux) as well |
@jdblischak @ihnorton linux is once again green. OSX is not; and I've switched from 10.14 to 10.15 in an attempt to rid errors of the form
which is weird b/c of the error
and I am using 10.15 :( |
... raw logs reveal 10.14 still appearing in log output. Trying a rerender ... |
…nda-forge-pinning 2024.03.01.21.24.14
d416ebc 🤞 |
Ugh, the osx-64 one failed with a spurious download error. That is the main one we need feedback on. I'm going to cancel and restart the CI jobs |
See also single-cell-data/TileDB-SOMA#2210 |
CI is green; this PR has done its job per our established procedure See also notes on single-cell-data/TileDB-SOMA#2210 that the |
More advice from @jdblischak |
The xref: #95 (comment)
|
Following our established procedure
See also #93 which addresses issues which have happened since 1.7.2 -- things involving our dependencies -- which have nothing to do with 1.8.0
See also single-cell-data/TileDB-SOMA#2219 for tracking.