Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] dylib-copy logic appears to be broken on MacOS #2210

Closed
johnkerl opened this issue Mar 5, 2024 · 3 comments · Fixed by #2221
Closed

[ci] dylib-copy logic appears to be broken on MacOS #2210

johnkerl opened this issue Mar 5, 2024 · 3 comments · Fixed by #2221
Assignees
Labels
bug Something isn't working

Comments

@johnkerl
Copy link
Member

johnkerl commented Mar 5, 2024

Please see:

Also note:

See also #2219 for tracking.

@jdblischak jdblischak self-assigned this Mar 5, 2024
@johnkerl johnkerl added the bug Something isn't working label Mar 6, 2024
@johnkerl johnkerl changed the title [ci] so-copy logic is broken on MacOS [ci] so-copy logic appears to be broken on MacOS Mar 6, 2024
@johnkerl johnkerl changed the title [ci] so-copy logic appears to be broken on MacOS [ci] dylib-copy logic appears to be broken on MacOS Mar 6, 2024
@johnkerl
Copy link
Member Author

johnkerl commented Mar 6, 2024

PR #2220 proves that PR #1937 did not entirely break dylib-copying for MacOS. All we need is an upcoming PR from @jdblischak.

@johnkerl
Copy link
Member Author

johnkerl commented Mar 6, 2024

#2221 should be the final fix; then we can close this issue.

@jdblischak
Copy link
Collaborator

PR #2220 proves that PR #1937 did not entirely break dylib-copying for MacOS

And it turns out that was a red herring. The actual problem was the setup.py flags --tiledb and --libtiledbsoma were broken, and only linux had a fall-back mechanism to overcome this failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants