-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add MacOS job to test shared object copying #2220
[ci] Add MacOS job to test shared object copying #2220
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
- Coverage 78.55% 72.13% -6.43%
==========================================
Files 137 103 -34
Lines 10689 6875 -3814
Branches 215 215
==========================================
- Hits 8397 4959 -3438
+ Misses 2194 1818 -376
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Backports to https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8176608919
I'm not convinced this is urgently needed in the branches |
Issue and/or context:
libtiledbsoma.so
intopackage_data
if it already exists #1937Changes:
Expands SO copying pipeline to include a macOS job
Notes for Reviewer:
I have good news and bad news. The good news is that I added a macOS job, and its behavior is correct! The bad news of course is that this means it doesn't explain the feedstock failures where the macOS builds fail to find the shared objects.
I suspect this is because the feedstock is still using the older
setup.py
with the flag--libtiledbsoma
(script). This was required pre-#1937. However, now that #1937 has been merged, we can now upgrade to the more modern alternative:update: replaced jinja2
{{ PYTHON }}
(for use inmeta.yaml
) with$PYTHON
(for use in separate build script)See also #2219 for tracking