Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add MacOS job to test shared object copying #2220

Merged

Conversation

jdblischak
Copy link
Collaborator

@jdblischak jdblischak commented Mar 6, 2024

Issue and/or context:

Changes:

Expands SO copying pipeline to include a macOS job

Notes for Reviewer:

I have good news and bad news. The good news is that I added a macOS job, and its behavior is correct! The bad news of course is that this means it doesn't explain the feedstock failures where the macOS builds fail to find the shared objects.

I suspect this is because the feedstock is still using the older setup.py with the flag --libtiledbsoma (script). This was required pre-#1937. However, now that #1937 has been merged, we can now upgrade to the more modern alternative:

export TILEDB_PATH=$PREFIX
export TILEDBSOMA_PATH=$PREFIX
$PYTHON -m pip install --no-deps . -vv

update: replaced jinja2 {{ PYTHON }} (for use in meta.yaml) with $PYTHON (for use in separate build script)

See also #2219 for tracking

@jdblischak jdblischak self-assigned this Mar 6, 2024
@johnkerl johnkerl changed the title Add macOS job to test shared object copying [ci] Add macOS job to test shared object copying Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #2220 (704d22a) into main (29c55e1) will decrease coverage by 6.43%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
- Coverage   78.55%   72.13%   -6.43%     
==========================================
  Files         137      103      -34     
  Lines       10689     6875    -3814     
  Branches      215      215              
==========================================
- Hits         8397     4959    -3438     
+ Misses       2194     1818     -376     
  Partials       98       98              
Flag Coverage Δ
libtiledbsoma 67.72% <ø> (+<0.01%) ⬆️
python ?
r 74.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.85% <ø> (+0.07%) ⬆️

@johnkerl johnkerl changed the title [ci] Add macOS job to test shared object copying [ci] Add MacOS job to test shared object copying Mar 6, 2024
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@johnkerl johnkerl merged commit f40e90b into single-cell-data:main Mar 6, 2024
21 checks passed
@jdblischak jdblischak deleted the python-so-copying-macos-pr branch March 6, 2024 18:02
@johnkerl
Copy link
Member

johnkerl commented Mar 6, 2024

Backports to release-1.8 and release-1.7 have failed to launch in CI multiple times, e.g.

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8176608919

Backport
Error: The process '/usr/bin/git' failed with exit code 128
Backport
HttpError: Resource not accessible by integration
Has anyone seen this before? I can debug but am already debugging multiple things simultaneously in an attempt to unblock multiple teams, so I thought I'd crowdsource first ...

I'm not convinced this is urgently needed in the branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants