Add check for Phase correlation transform

[ruqayya]

Likewise other intermediate transform, Phase cross-correlation transform should only be applied if it improves the DICE overlap.

[shaneahmed]

I think as there is an if statement you may need to add a test.
You can create a new function that would help to add a quick test.

[ruqayya]

I think as there is an if statement you may need to add a test. You can create a new function that would help to add a quick test.

'If statement' is already covered by the existing test functions such as test_register_output_with_initializer. The phase cross correlation transform for the images that we are using for testing results in low dice value as compared to previous dice value and hence "if statement" is executed on calling register function. Do we still need to have a separate function?

[shaneahmed]

I think as there is an if statement you may need to add a test. You can create a new function that would help to add a quick test.

'If statement' is already covered by the existing test functions such as test_register_output_with_initializer. The phase cross correlation transform for the images that we are using for testing results in low dice value as compared to previous dice value and hence "if statement" is executed on calling register function. Do we still need to have a separate function?

no if it is already covered then it is fine. As it is a new change, I thought it might be required. Once tests are passed we will know if it is covered.

[codecov]

Codecov Report

Merging #645 (6aef433) into develop (3614f61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop     #645    +/-   ##
=========================================
  Coverage    99.78%   99.78%            
=========================================
  Files           65       65            
  Lines         7075     7079     +4     
  Branches      1397     1160   -237     
=========================================
+ Hits          7060     7064     +4     
  Misses           7        7            
  Partials         8        8            

Impacted Files	Coverage Δ
tiatoolbox/tools/registration/wsi_registration.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shaneahmed]

Thanks @ruqayya