Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 1.5.0 #757

Merged
merged 608 commits into from
Dec 15, 2023
Merged

🔖 Release 1.5.0 #757

merged 608 commits into from
Dec 15, 2023

Conversation

shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Dec 15, 2023

1.5.0 (2023-12-15)

Major Updates and Feature Improvements

Changes to API

Bug Fixes and Other Changes

Development related changes

Full Changelog: v1.4.0...v1.5.0

pre-commit-ci bot and others added 30 commits August 30, 2022 10:27
updates:
- [github.com/executablebooks/mdformat: 0.7.14 → 0.7.16](executablebooks/mdformat@0.7.14...0.7.16)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Use app.add_css_file.
- Update requirements.
- Sphinx 4.5.0 does not resolve on python 3.7 now. The requirement has been downgraded to 4.3.2 and checked html build locally. It passes the build and the output html looks fine.
- Changed the base requirements to a single file `requirements.txt`. `requirements_dev.txt` installs any additional dependencies on top of base requirements. conda environment is also based on `requirements.txt` and `requirements_dev.txt` now.
- This removes the need for pre-commit check. However, we should modify the pre-commit check according to this update.

Co-authored-by: mostafajahanifar <74412979+mostafajahanifar@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- DOC: Edit metadata to make all cells visible to rtd.
- MAINT: edit raw source of list for jnb-rtd consistency.
- MAINT: Remove redundant initial ">" and incorrect double quotes. Then edit for clarity.
- MAINT: change "temp" to "tmp"
- MAINT: change "tail --lines 1" to "tail -n 1". Change wording around ON_GPU.
- MAINT: correct typo
- BUG: Remove pretence that ON_GPU=False is viable/meaningful with current software packages.
- MAINT: Run Colab with GPU and make requisite changes.
- MAINT: Change number of WORKERS to 4. Add comment that the notebook crashes if run without Cuda-enabled GPU.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Add SCCNN architecture.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Co-authored-by: Mostafa Jahanifar <74412979+mostafajahanifar@users.noreply.github.com>
Co-authored-by: Dang Vu <24943262+vqdang@users.noreply.github.com>
- Add MapDe architecture.

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Co-authored-by: Mostafa Jahanifar <74412979+mostafajahanifar@users.noreply.github.com>
- Corrects a single typo in a python module.
updates:
- [github.com/psf/black: 22.6.0 → 22.8.0](psf/black@22.6.0...22.8.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Adds a GitHub workflow which installs openslide and openjpeg binaries and then runs pip install from the GitHub repo which will install the latest develop version. It then checks that `import tiatoolbox` runs without error.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Change md cells only
1. Insert empty line after each heading
2. Replace html format for links. html is a subset of md, but is not
understood by rtd.
2. Replace unmatched left parenthesis in url by html tag
3. Change "tail --lines 1" to "tail -n 1"
4. Remove initial ">". JNB-RTD-Compatible indentation is not possible.
5. Change combination of backtick and asterisk to asterisk only.
6. Change ON_GPU from False to True in preparation for bug fix.
7. Cut code cell into three pieces to make it easier to find the bug
Obtain the correct legend from overlay-prediction-mask.
Save this version with ON_GPU = False with all output.
Run under Macos without GPU (ON_GPU == False) and save with outpu


Co-authored-by: Mostafa Jahanifar <74412979+mostafajahanifar@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- Remove flake8-sql checks as this is not being maintained.
  - pgjones/flake8-sql#21

Co-authored-by: Shan Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- DOC: Edit metadata to remove hidden cells. Fix one heading
- MAINT: Remove incorrect initial ?>?. Delete incorect double quotes.
- MAINT: Remove incooect double quotes. Improve text. Improve code comment.
- MAINT: Remove incorrect initial ">"
- MAINT: insert empty line before list several times
- MAINT: Insert spaces round backticked words and phrases, where appropriate
Note: The develop version of visualization.py is necessary for correct legends.

Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Use ABC for PatchExtractor
- For SQLExpression, couldn't find an easy way to define it using ABC. Probably ABC is not necessary here? @John-P Please can you check?
- Fix DeepSource error Module imports itself PYL-W0406
  -  Refactored tiatoolbox/models/abc to tiatoolbox/models/models_abc
- Fix typos
- Add typehints for PatchExtractor

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- Adds the functionality described in[ #446 ](#446 ).
  - Adds a `min_mask_ratio` parameter to the patchextractor class so that one can define it as a percentage of the patch area that needs to include mask.

Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: Mostafa Jahanifar <74412979+mostafajahanifar@users.noreply.github.com>
- Change name of notebook to avoid rtd search ambiguity and insert empty line below
- Implement jnb-rtd consistency rules
- Implement rules for JNB-RTD consistency and fix a few typos.
- Insert missing "the"

Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Implement rules for JNB-RTD consistency (see Wiki)
- Change working slightly


Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Change html theme to furo (https://pradyunsg.me/furo/quickstart/) for better visibility of links.

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: David Epstein <22086916+DavidBAEpstein@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- Fix docstring rendering and typos.
- Use `code-block` directive for json.
- Exclude `requirements.txt` from sphinx build.
- Fix hyperlinks.
- Fix indentation for bullet points.
- Fix underline for headings.
- Fix GitHub links
- Fix interpreted text or phrase reference start-string without end-string.

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix spacing around backticked words.
- Unhide hidden cells. Change "tail --line 1" to "tail -n 1" Incorporate changes implemented by pre-commit hooks.
- Change "tail --line 1" to "tail -n 1". Correct spacing around backticked word.
- Rewrite text cell on restarting runtime, and replace non-ascii right-arrow by ampersand encoding. Apply pre-commit hooks.
- Edit notebooks.rst to remove nbgallery
- Fix indent
- Remove nbgallery from full pipeline and inference pipeline
- Update README.md
- Adds feature matching functions for deep feature based registration.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Add `docs/requirements.txt` to `requirements_dev.txt`

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix spacing around backticked words.
- Unhide hidden cells. Change "tail --line 1" to "tail -n 1" Incroporate changes implrmented by pre-commit hooks.
- Change "tail --line 1" to "tail -n 1". Correct spacing around backticked word.
- Rewrite text cell on restarting runtime, and replace non-ascii right-arrow by ampersand encoding. Apply pre-commit hooks.
- Unhide hidden cells
- Rewrite text cell about restarting runtime under Colab. Replace non-ascii em-dash by " &mdash;". Pre-commit hooks.
- Redo previous commit more carefully.
- Fixes the colorbar bug cropping in `test_visualization.py`
- Use `requirements.txt` in `setup.py`

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- Adds PR adds macOS pip install test cases to the GitHub workflow.

Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Setup workflow on push as GitHub variables for pull request do not work on push.
- Update citation in README.md and CITATION.cff

Co-authored-by: John Pocock <John-P@users.noreply.github.com>
- Run pip install workflow only on requirements file
- Update numpy requirements
- Improve TIAToolbox import using lazy imports.
- Improves importing `import tiatoolbox` by 10 times.
- This will improve execution of cli.

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: John Pocock <John-P@users.noreply.github.com>
Jiaqi-Lv and others added 12 commits November 22, 2023 12:28
Add `mypy` checks to
  - `tiatoolbox/utils/exceptions.py`
  - `tiatoolbox/utils/magic.py`
  - `tiatoolbox/utils/metrics.py` 
  - `tiatoolbox/utils/transforms.py`
  - `tiatoolbox/tiatoolbox.py`

---------

Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Add `utils/misc.py` to mypy

---------

Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Update Dependency Link for `pytorch cuda` Version
- Fixes #732.
- masks should be returned instead of [mask].
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.6 → v0.1.7](astral-sh/ruff-pre-commit@v0.1.6...v0.1.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Add `mypy` checks to `image.py`
Adds the bokeh visualization.

The main features this PR adds:

Visualization interface with following features:

1. Viewing of slides
2. Viewing of annotation-store overlays
3. Viewing of graph overlays
4. Viewing of low-res image overlays
5. Dual linked window functionality
6. Various options to control how annotations are displayed/which annotations are displayed
7. Run hovernet on a selected region
8. Inspect annotation properties with double-click
9. Slide info is shown below main view window

Adds cli command `tiatoolbox visualize` to launch UI. The usage has been changed to either:

`tiatoolbox visualize --base-path path\to\parent\of\slides_and_overlays`

or

`tiatoolbox visualize --slides path\to\slides --overlays path\to\overlays`

Adds a documentation page on how to use the UI, and providing some examples of how to create/modify an annotation store for visualization in some common scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: Abdol A <u2271662@live.warwick.ac.uk>
- Add `mypy` checks to `visualization.py`
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51f504b) 99.77% compared to head (9a207d4) 99.91%.

❗ Current head 9a207d4 differs from pull request most recent head e7eac32. Consider uploading reports for the commit e7eac32 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
+ Coverage   99.77%   99.91%   +0.13%     
==========================================
  Files          63       69       +6     
  Lines        6782     8518    +1736     
  Branches     1352     1637     +285     
==========================================
+ Hits         6767     8511    +1744     
+ Misses          7        0       -7     
+ Partials        8        7       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix Error in `06-semantic-segmentation` related to `overlay_prediction_mask`
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@shaneahmed shaneahmed merged commit bba59ba into master Dec 15, 2023
2 checks passed
@shaneahmed shaneahmed deleted the pre-release branch December 15, 2023 22:28
@shaneahmed shaneahmed self-assigned this Dec 15, 2023
@shaneahmed shaneahmed added this to the Release v1.5.0 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.