♻️ Remove POWER from sqlite-dist Calculations
#769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #769 +/- ##
=========================================
Coverage 99.91% 99.91%
=========================================
Files 69 69
Lines 8518 8518
Branches 1637 1382 -255
=========================================
Hits 8511 8511
Partials 7 7 ☔ View full report in Codecov by Sentry. |
shaneahmed
changed the title
POWER from sqlite-dist Calculations
|
This passes on Windows now. Thanks @measty |
shaneahmed
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of POWER from distance calculations to address issue #692
Replaces use of POWER with explicit multiplication.