Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI response should be in embed #1046

Merged
merged 4 commits into from
Mar 12, 2024
Merged

AI response should be in embed #1046

merged 4 commits into from
Mar 12, 2024

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Mar 6, 2024 •
edited
Loading

Here's how new AI generated responses look like:

gpt-response-embed

@ankitsmt211
AI response should be in embed
37c0ce4 
* helper method to generate embed
* remove AI parser class that partitioned responses & related tests
* refactor dismiss button on generated responses
* update docs
@ankitsmt211 ankitsmt211 self-assigned this Mar 6, 2024
@ankitsmt211 ankitsmt211 requested review from a team as code owners March 6, 2024 23:09
SquidXTV
SquidXTV approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@SquidXTV SquidXTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D
Btw you want to change the user icon to chatgpt icon?
Are we even allowed to?

@ankitsmt211
Copy link
Member Author

Btw you want to change the user icon to chatgpt icon? Are we even allowed to?

that would be really nice if we could do that, i can't think of a way to do that. Prolly would need store random asset somewhere and get a url perhaps that we can pass for author.

@SquidXTV
Copy link
Member

SquidXTV commented Mar 7, 2024

Btw you want to change the user icon to chatgpt icon? Are we even allowed to?

that would be really nice if we could do that, i can't think of a way to do that. Prolly would need store random asset somewhere and get a url perhaps that we can pass for author.

https://en.m.wikipedia.org/wiki/File:ChatGPT_logo.svg
https://chat.openai.com/apple-touch-icon.png
https://chat.openai.com/favicon-32x32.png

@ankitsmt211
Copy link
Member Author

ankitsmt211 commented Mar 7, 2024 •
edited
Loading

I will give these a try, also i linked a new issue #928 since it will be resolved as well so we can touch 3 of the issues with this merge.

update: tried using urls as string but embeds were blank without an avatar, can hopefully be resolved in later PR if it's somehow possible.

@ankitsmt211 ankitsmt211 mentioned this pull request Mar 11, 2024
Open
@ankitsmt211 ankitsmt211 merged commit 6dd670a into Together-Java:develop Mar 12, 2024
9 checks passed
Taz03 pushed a commit that referenced this pull request Mar 13, 2024
@ankitsmt211 @Taz03
AI response should be in embed (#1046)
d161c97 
* AI response should be in embed
* helper method to generate embed
* remove AI parser class that partitioned responses & related tests
* refactor dismiss button on generated responses
* update docs
* remove AIResponseParserTest
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taz03 Taz03 Taz03 approved these changes

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees

@ankitsmt211 ankitsmt211

Labels
priority: major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChatGpt Auto-Answer posts multiple mini messages ChatGPT Auto-answer should be in an embed
3 participants
@ankitsmt211 @SquidXTV @Taz03