Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for chains #413

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: add support for chains #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/nft.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const getReputationScore = async (tokenId: string, address: string) => {

async function getProfiles(address: string) {
let profiles: Array<any> = [];
const supportedChainIds = [11155111];
const supportedChainIds = [84532, 42161];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider moving chain IDs to configuration

The hard-coded chain IDs should be moved to a configuration file for better maintainability and environment-specific settings.

- const supportedChainIds = [84532, 42161];
+ const supportedChainIds = config.chains.supported;

Committable suggestion skipped: line range outside the PR's diff.

for (let i = 0; i < supportedChainIds.length; i++) {
const chainProfiles = await ociService.getProfiles(address, supportedChainIds[i]);
profiles = profiles.concat(chainProfiles);
Expand Down