Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DBus desktop notification support. #209

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 7, 2024

This is nicer than the Qt built-in tray notifications. It only works on Linux. On other systems, tray notifications are pretty ok.

Fixes #208.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 7, 2024
@github-actions github-actions bot added the enhancement New feature for the user, not a new feature for build script label Dec 7, 2024
@iphydf iphydf force-pushed the dbus-notify branch 7 times, most recently from 03b9dd3 to 61e8315 Compare December 10, 2024 01:26
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.

Project coverage is 11.02%. Comparing base (2d6bb67) to head (61e8315).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...tform/desktop_notifications/desktopnotify_dbus.cpp 0.00% 108 Missing ⚠️
...c/platform/desktop_notifications/desktopnotify.cpp 0.00% 14 Missing ⚠️
src/widget/widget.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   11.04%   11.02%   -0.02%     
==========================================
  Files         294      295       +1     
  Lines       21226    21369     +143     
==========================================
+ Hits         2344     2356      +12     
- Misses      18882    19013     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the dbus-notify branch 20 times, most recently from ab43ffc to 1897c1d Compare December 11, 2024 19:56
@iphydf iphydf force-pushed the dbus-notify branch 4 times, most recently from 681cbf4 to 891f926 Compare December 11, 2024 22:12
This is nicer than the Qt built-in tray notifications. It only works on
Linux. On other systems, tray notifications are pretty ok.
@toktok-releaser toktok-releaser merged commit fb4df42 into TokTok:master Dec 16, 2024
24 checks passed
@iphydf iphydf deleted the dbus-notify branch December 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Development

Successfully merging this pull request may close these issues.

[Regression]: The notification is missing a friend's avatar
3 participants