Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a CI check to run the macOS distributable binary. #250

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 15, 2024

We run it on a pristine macOS instance without anything we may have done to the build instance.

Requires the DBus PR #209 first.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 15, 2024
@github-actions github-actions bot added the chore Updating grunt tasks etc; no production code change label Dec 15, 2024
@iphydf iphydf force-pushed the test-dmg branch 3 times, most recently from 8620390 to d74a0ca Compare December 15, 2024 21:53
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.06%. Comparing base (3ad53cf) to head (d74a0ca).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   11.08%   11.06%   -0.02%     
==========================================
  Files         294      294              
  Lines       21254    21258       +4     
==========================================
- Hits         2356     2353       -3     
- Misses      18898    18905       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the test-dmg branch 4 times, most recently from 91f26ef to 42ad6e7 Compare December 15, 2024 23:26
@iphydf iphydf added the packaging Packaging label Dec 16, 2024
@iphydf iphydf marked this pull request as ready for review December 16, 2024 12:25
@iphydf iphydf requested a review from a team as a code owner December 16, 2024 12:25
We run it on a pristine macOS instance without anything we may have done
to the build instance.
@toktok-releaser toktok-releaser merged commit f65c263 into TokTok:master Dec 16, 2024
37 checks passed
@iphydf iphydf deleted the test-dmg branch December 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change packaging Packaging
Development

Successfully merging this pull request may close these issues.

3 participants