cleanup: Remove unnecessary path cleaner in tox logger. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cleanup
iphydf
force-pushed
the
tox-clean-path
branch
2 times, most recently
from
d79d36b to
0ddc5d2
Compare
robinlinden
approved these changes
Dec 21, 2024
Toxcore already cleans this path and only passes the filename. This path cleaner wasn't great to begin with (requiring the source directory name to be c-toxcore).
iphydf
force-pushed
the
tox-clean-path
branch
from
0ddc5d2 to
3612acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toxcore already cleans this path and only passes the filename. This path cleaner wasn't great to begin with (requiring the source directory name to be c-toxcore).
This change is