Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove unnecessary path cleaner in tox logger. #266

Merged
merged 1 commit into from
Dec 21, 2024

cleanup: Remove unnecessary path cleaner in tox logger.

3612acc
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Remove unnecessary path cleaner in tox logger. #266

cleanup: Remove unnecessary path cleaner in tox logger.
3612acc
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 21, 2024 in 1s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Remove unnecessary path cleaner in tox logger.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : cleanup: Remove unnecessary path cleaner in tox logger.

Toxcore already cleans this path and only passes the filename. This path
cleaner wasn't great to begin with (requiring the source directory name
to be c-toxcore).
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : Toxcore already cleans this path and only passes the filename. This path cleaner wasn't great to begin with (requiring the source directory name to be c-toxcore).

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}