Add a snapshot test for Path SVG layout
#412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
added
test suite
…apshot-tests # Conflicts: # Package.swift # Tests/TokamakStaticHTMLTests/HTMLTests.swift
MaxDesiatov
changed the title
LazyVGrid CSS layoutPath SVG layout
MaxDesiatov
commented
Jun 20, 2021
MaxDesiatov
commented
Jun 20, 2021
| @@ -40,20 +40,9 @@ final class ReconcilerStressTests: XCTestCase { | |||
| let renderer = TestRenderer(SpookyHanger()) | |||
| let root = renderer.rootTarget | |||
|
|
|||
| return | |||
There was a problem hiding this comment.
This test was invalid, but the return statement made this undiscoverable. Cleaning that up and simplifying the test to actually pass.
MaxDesiatov
commented
Jun 20, 2021
| import Foundation | ||
|
|
||
| /// The outline of a 2D shape. | ||
| public struct Path: Equatable, LosslessStringConvertible { |
There was a problem hiding this comment.
This is a smaller version of the original Path.swift that satisfies linter's file length constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #253.
This adds a dependency on the SnapshotTesting library, which allows testing our SVG layout algorithm end-to-end. We use the
--screenshotflag of Chromium-based browsers (MS Edge in this case) to produce a PNG snapshot of a view rendered withStaticHTMLRenderer.This test works only on macOS for now due to its dependency on
NSImage, but that should be fine as we'd expect the same SVG output to be rendered in the same way on all platforms.