Add a snapshot test for Path SVG layout

.github/workflows/ci.yml

@@ -33,10 +33,11 @@ jobs:
         shell: bash
         run: |
           set -ex
-          sudo xcode-select --switch /Applications/Xcode_12.3.app/Contents/Developer/
+          sudo xcode-select --switch /Applications/Xcode_12.4.app/Contents/Developer/
           # avoid building unrelated products for testing by specifying the test product explicitly
           swift build --product TokamakPackageTests
-          `xcrun --find xctest` .build/debug/TokamakPackageTests.xctest
+          `xcrun --find xctest` .build/debug/TokamakPackageTests.xctest ||
+            find /var/folders -iname SnapshotTests -exec cp -r {} . \;
 
           rm -rf Sources/TokamakGTKCHelpers/*.c
 
@@ -55,6 +56,13 @@ jobs:
 
           ./benchmark.sh
 
+      - name: Upload failed snapshots
+        uses: actions/upload-artifact@v2
+        if: ${{ failure() }}
+        with:
+          name: Failed snapshots
+          path: SnapshotTests
+
   gtk_macos_build:
     runs-on: macos-latest
 
@@ -64,7 +72,7 @@ jobs:
         shell: bash
         run: |
           set -ex
-          sudo xcode-select --switch /Applications/Xcode_12.3.app/Contents/Developer/
+          sudo xcode-select --switch /Applications/Xcode_12.4.app/Contents/Developer/
 
           brew install gtk+3
 

Package.swift

@@ -53,9 +53,19 @@ let package = Package(
       url: "https://github.com/swiftwasm/JavaScriptKit.git",
       .upToNextMinor(from: "0.10.0")
     ),
-    .package(url: "https://github.com/OpenCombine/OpenCombine.git", from: "0.12.0"),
-    .package(url: "https://github.com/swiftwasm/OpenCombineJS.git", .upToNextMinor(from: "0.1.1")),
-    .package(name: "Benchmark", url: "https://github.com/google/swift-benchmark", from: "0.1.0"),
+    .package(
+      url: "https://github.com/OpenCombine/OpenCombine.git",
+      from: "0.12.0"
+    ),
+    .package(
+      url: "https://github.com/swiftwasm/OpenCombineJS.git",
+      .upToNextMinor(from: "0.1.1")
+    ),
+    .package(
+      name: "Benchmark",
+      url: "https://github.com/google/swift-benchmark",
+      from: "0.1.0"
+    ),
     .package(
       name: "SnapshotTesting",
       url: "https://github.com/pointfreeco/swift-snapshot-testing.git",
@@ -190,7 +200,7 @@ let package = Package(
         .product(
           name: "SnapshotTesting",
           package: "SnapshotTesting",
-          condition: .when(platforms: [.macOS, .linux])
+          condition: .when(platforms: [.macOS])
         ),
       ],
       exclude: ["__Snapshots__"]

Sources/TokamakCore/MountedViews/MountedApp.swift

@@ -41,7 +41,8 @@ final class MountedApp<R: Renderer>: MountedCompositeElement<R> {
 
   /// Mounts a child scene within the app.
   /// - Parameters:
-  ///   - renderer: A instance conforming to the `Renderer` protocol to render the mounted scene with.
+  ///   - renderer: An instance conforming to the `Renderer` protocol to render the mounted
+  ///   scene with.
   ///   - childBody: The body of the child scene to mount for this app.
   /// - Returns: Returns an instance of the `MountedScene` class that's already mounted in this app.
   private func mountChild(_ renderer: R, _ childBody: _AnyScene) -> MountedScene<R> {

Sources/TokamakCore/MountedViews/MountedCompositeView.swift

@@ -34,8 +34,8 @@ final class MountedCompositeView<R: Renderer>: MountedCompositeElement<R> {
     mountedChildren = [child]
     child.mount(before: sibling, on: self, with: reconciler)
 
-    // `_TargetRef` (and `TargetRefType` generic eraser protocol it conforms to) is a composite view, so it's enough
-    // to check for it only here.
+    // `_TargetRef` (and `TargetRefType` generic eraser protocol it conforms to) is a composite
+    // view, so it's enough check for it only here.
     if var targetRef = view.view as? TargetRefType {
       // `_TargetRef` body is not always a host view that has a target, need to traverse
       // all descendants to find a `MountedHostView<R>` instance.

Sources/TokamakCore/Reflection/Layouts/FieldDescriptor.swift

@@ -32,6 +32,7 @@ func _getTypeByMangledNameInContext(
   _ genericArguments: UnsafeRawPointer?
 ) -> Any.Type?
 
+// swiftlint:disable:next line_length
 /// https://github.com/apple/swift/blob/f2c42509628bed66bf5b8ee02fae778a2ba747a1/include/swift/Reflection/Records.h#L160
 struct FieldDescriptor {
   let mangledTypeNameOffset: Int32