Fix for player overhead names not disapearing. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason in the code there was a for loop to iterate over players and not over the created gamertags dict. This resulted in mp gamer tags not disaprearing when checkbox unchecked.
|
@Explooosion-code The reason is very simple. This native was undocumented when it was implemented and the player tag ids were always between 1 and 255 back then. This has probably changed since onesync (infinity) |
|
Ok, that makes sense 🤷 | I tested this on onesync infinity off and on and worked on both. Hope this is helpful 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason in the code there was a for loop to iterate over players and not over the created gamertags dict. This resulted in mp gamer tags not disaprearing when checkbox unchecked.