We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
Yes.
When I use the invalid schema(https, http) with explicit port in uri
//dev config, host=domain:port String url = String.format("http://%s/%s", host, "websocket"); ws = new WebSocketClient(new URI(url))
MayBe, I can't find the potential the problem, because it can run without exception.
But, it will failed when we omit the port in uri. and It will throw an exception:"unkown schema http"
// prod config, host=domain String url = String.format("http://%s/%s", host, "websocket"); ws = new WebSocketClient(new URI(url)) `
I'm alway frustrated when run failed only with different config in prod environment.
I think we should allow user to find the potential problem during development.
Describe the solution you'd like
always check the schema and throw exception on invalid schema, regardless whether the port is explicit set(no matter uri.getPort() == -1).
The text was updated successfully, but these errors were encountered:
@yindex thx for creating the issue.
Sorry, something went wrong.
Use appropriate schema in any case TooTallNate#1026
38a7aed
add unit test for schema check
af28db4
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
Yes.
When I use the invalid schema(https, http) with explicit port in uri
MayBe, I can't find the potential the problem, because it can run without exception.
But, it will failed when we omit the port in uri. and It will throw an exception:"unkown schema http"
I'm alway frustrated when run failed only with different config in prod environment.
I think we should allow user to find the potential problem during development.
Describe the solution you'd like
always check the schema and throw exception on invalid schema, regardless whether the port is explicit set(no matter uri.getPort() == -1).
The text was updated successfully, but these errors were encountered: