-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use appropriate schema in any case #1025
Conversation
Hello @yindex, could you please open a PR for this issue so everyone better understands the issue. Best regards, |
sorry, for miss that, I will open an issue with detail and Motivation for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Could you create two simple tests which simple check for the illegal argument exception when using http and https and no exception when using ws and wss
add unit test for schema check
38a7aed
to
af28db4
Compare
two sample test added Best regards, |
@yindex thx for your changes and the tests! Best regards, |
Enforce Use appropriate schema in any case
Description
throw exception if use invalid schema in websocket client.
Related Issue
Fixes #1026
Motivation and Context
I think we should force users to use valid schema. Avoid confusion when using the invalid schema without throwing an exception
How Has This Been Tested?
Types of changes
Checklist: