Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate schema in any case #1025

Merged
merged 2 commits into from
May 24, 2020
Merged

Use appropriate schema in any case #1025

merged 2 commits into from
May 24, 2020

Conversation

yindex
Copy link

@yindex yindex commented May 18, 2020

Enforce Use appropriate schema in any case

Description

throw exception if use invalid schema in websocket client.

Related Issue

Fixes #1026

Motivation and Context

I think we should force users to use valid schema. Avoid confusion when using the invalid schema without throwing an exception

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Copy link
Collaborator

marci4 commented May 18, 2020

Hello @yindex,

could you please open a PR for this issue so everyone better understands the issue.
Thx a lot.

Best regards,
Marcel

@yindex
Copy link
Author

yindex commented May 18, 2020

sorry, for miss that, I will open an issue with detail and Motivation for that

@yindex
Copy link
Author

yindex commented May 19, 2020

Hello @yindex,

could you please open a PR for this issue so everyone better understands the issue.
Thx a lot.

Best regards,
Marcel

an issue #1026 for the PR has been open

Copy link
Collaborator

@marci4 marci4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Could you create two simple tests which simple check for the illegal argument exception when using http and https and no exception when using ws and wss

@marci4 marci4 added this to the Release 1.5.2 milestone May 23, 2020
Pawan Gupta and others added 2 commits May 23, 2020 21:12
@yindex yindex force-pushed the master branch 2 times, most recently from 38a7aed to af28db4 Compare May 23, 2020 16:51
@yindex
Copy link
Author

yindex commented May 24, 2020

Changes look good.
Could you create two simple tests which simple check for the illegal argument exception when using http and https and no exception when using ws and wss

two sample test added

Best regards,
yindex

@marci4
Copy link
Collaborator

marci4 commented May 24, 2020

@yindex thx for your changes and the tests!

Best regards,
Marcel

@marci4 marci4 merged commit a89d4ae into TooTallNate:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force client to use the valid schema
2 participants