Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move HMODULE m declaration to top #616

Merged
merged 1 commit into from
May 19, 2015

Conversation

cosmosgenius
Copy link
Contributor

The declaration of the m variable not on top causes the build to fail on VS2010(C89), Window 7 x64.
Providing solution based on stackoverflow answer.

@TooTallNate
Copy link
Contributor

/cc @piscisaureus

@piscisaureus
Copy link
Contributor

lgtm, ship it

piscisaureus pushed a commit to nodejs/node that referenced this pull request May 19, 2015
This fixes building compiled addons with Visual Studio 2010.

PR-URL: nodejs/node-gyp#616
Reviewed-By: Bert Belder <bertbelder@gmail.com>
piscisaureus pushed a commit to nodejs/node that referenced this pull request May 19, 2015
This fixes building compiled addons with Visual Studio 2010.

PR-URL: nodejs/node-gyp#616
Reviewed-By: Bert Belder <bertbelder@gmail.com>
TooTallNate added a commit that referenced this pull request May 19, 2015
@TooTallNate TooTallNate merged commit 7ea00c9 into nodejs:master May 19, 2015
@kkoopa
Copy link

kkoopa commented May 19, 2015

Do note that io.js 2.0 will not build with VS 2010 at all due to V8 4.2.

iarna pushed a commit to npm/node that referenced this pull request May 22, 2015
This fixes building compiled addons with Visual Studio 2010.

PR-URL: nodejs/node-gyp#616
Reviewed-By: Bert Belder <bertbelder@gmail.com>
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
This fixes building compiled addons with Visual Studio 2010.

PR-URL: nodejs/node-gyp#616
Reviewed-By: Bert Belder <bertbelder@gmail.com>
@cosmosgenius cosmosgenius deleted the win-c89-compile-fix branch January 4, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants