This repository has been archived by the owner on Apr 5, 2018. It is now read-only.
move HMODULE m declaration to top #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for the function to be C89 compatible, so it compiles with Visual Studio 2013.
|
Is there a specific case in consumer code where it fails? I'm asking because ever since this was added, we are compiling with VS2013 without an issue. |
|
I had a problem compiling this with VS2013 and also older VS versions. My VS installation is standard, so I'm not sure if it could be tweaked to support C99. node-gyp had this merged in April: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for the function to be C89 compatible, so it compiles with Visual Studio 2013.