move HMODULE m declaration to top #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @piscisaureus |
|
lgtm, ship it |
piscisaureus
pushed a commit
to nodejs/node
that referenced
this pull request
May 19, 2015
This fixes building compiled addons with Visual Studio 2010. PR-URL: nodejs/node-gyp#616 Reviewed-By: Bert Belder <bertbelder@gmail.com>
piscisaureus
pushed a commit
to nodejs/node
that referenced
this pull request
May 19, 2015
This fixes building compiled addons with Visual Studio 2010. PR-URL: nodejs/node-gyp#616 Reviewed-By: Bert Belder <bertbelder@gmail.com>
TooTallNate
added a commit
that referenced
this pull request
May 19, 2015
move HMODULE m declaration to top
|
Do note that io.js 2.0 will not build with VS 2010 at all due to V8 4.2. |
iarna
pushed a commit
to npm/node
that referenced
this pull request
May 22, 2015
This fixes building compiled addons with Visual Studio 2010. PR-URL: nodejs/node-gyp#616 Reviewed-By: Bert Belder <bertbelder@gmail.com>
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
This fixes building compiled addons with Visual Studio 2010. PR-URL: nodejs/node-gyp#616 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaration of the m variable not on top causes the build to fail on VS2010(C89), Window 7 x64.
Providing solution based on stackoverflow answer.