-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump pydantic from 1.10.9 to 2.0.2 #509
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
91d46e1
build(deps): bump pydantic from 1.10.9 to 2.0.2
dependabot[bot] 833a373
feat: from the pydantic-2 documentation
Sanix-Darker 3d3fa2f
feat: conditional post_ini based on pydantic version
Sanix-Darker c59f490
fix: another specificity from the migration
Sanix-Darker 4fb8045
add support for pydantic 1 and 2 in the CI for lint and test
Sanix-Darker e09fe21
chore: update the CHANGELOG to get ready for a bump
Sanix-Darker 40c3286
feat: update from PR review
Sanix-Darker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,18 +10,35 @@ jobs: | |
python-version: | ||
- "3.10" | ||
- "3.11" | ||
pydantic-version: | ||
- "^1.10" | ||
- "^2.0" | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: install_system_deps | ||
run: sudo make install_system_deps | ||
|
||
- name: Update Pydantic version on the toml & lock | ||
run: | | ||
pip install -U pip poetry | ||
# we update the pydantic version corresponding to the matrix | ||
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note : i programmatically update the pyproject.toml file here on 'pydantic = ...' line for CI purposes |
||
poetry lock --no-update | ||
env: | ||
PYDANTIC_VERSION: ${{ matrix.pydantic-version }} | ||
|
||
- name: install | ||
run: make install | ||
|
||
- name: lint | ||
run: make lint | ||
|
||
- name: mypy | ||
run: make mypy | ||
|
||
|
@@ -32,19 +49,37 @@ jobs: | |
python-version: | ||
- "3.10" | ||
- "3.11" | ||
pydantic-version: | ||
- "^1.10" | ||
- "^2.0" | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: install_system_deps | ||
run: sudo make install_system_deps | ||
|
||
- name: Update Pydantic version on the toml & lock | ||
run: | | ||
pip install -U pip poetry | ||
# we update the pydantic version corresponding to the matrix | ||
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml | ||
poetry lock --no-update | ||
env: | ||
PYDANTIC_VERSION: ${{ matrix.pydantic-version }} | ||
|
||
- name: install | ||
run: make install | ||
|
||
- name: test | ||
run: make test | ||
env: | ||
FTP_PATH: ${{ secrets.FTP_PATH }} | ||
PYDANTIC_VERSION: ${{ matrix.pydantic-version }} | ||
|
||
- name: Upload coverage | ||
uses: codecov/codecov-action@v3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the
make lint
isn't it a bit useless?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the job is called "lint" but we have a "mypy" checker on it... should we really remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it like that