Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump pydantic from 1.10.9 to 2.0.2 #509

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 6, 2023

Bumps pydantic from 1.10.9 to 2.0.2.

Release notes

Sourced from pydantic's releases.

v2.0.2 2023-07-05

What's Changed

New Contributors

Full Changelog: pydantic/pydantic@v2.0.1...v2.0.2

v2.0.1 2023-07-04

What's Changed

... (truncated)

Changelog

Sourced from pydantic's changelog.

v2.0.2 (2023-07-05)

See the full changelog here

v2.0.1 (2023-07-04)

First patch release of Pydantic V2

  • Extra fields added via setattr (i.e. m.some_extra_field = 'extra_value') are added to .model_extra if model_config extra='allowed'. Fixed #6333, #6365 by @​aaraney
  • Automatically unpack JSON schema '$ref' for custom types, #6343 by @​adriangb
  • Fix tagged unions multiple processing in submodels, #6340 by @​suharnikov

See the full changelog here

v2.0 (2023-06-30)

Pydantic V2 is here! 🎉

See this post for more details.

See the full changelog here

v2.0b3 (2023-06-16)

Third beta pre-release of Pydantic V2

See the full changelog here

v2.0b2 (2023-06-03)

Add from_attributes runtime flag to TypeAdapter.validate_python and BaseModel.model_validate.

See the full changelog here

v2.0b1 (2023-06-01)

First beta pre-release of Pydantic V2

See the full changelog here

v2.0a4 (2023-05-05)

Fourth pre-release of Pydantic V2

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Jul 6, 2023
@github-actions github-actions bot removed the python label Jul 6, 2023
@dependabot dependabot bot force-pushed the dependabot/pip/pydantic-2.0.2 branch 2 times, most recently from 9438e8a to 3756778 Compare July 6, 2023 15:23
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.9 to 2.0.2.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v1.10.9...v2.0.2)

---
updated-dependencies:
- dependency-name: pydantic
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/pydantic-2.0.2 branch from 3756778 to 91d46e1 Compare July 12, 2023 05:27
__post_init_post_parse__ is no longer supported, and we can replace it
with __post_init__ in our case.
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d5325ad) 100.00% compared to head (40c3286) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #509   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          837       848   +11     
=========================================
+ Hits           837       848   +11     
Impacted Files Coverage Δ
peakina/datasource.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sanix-Darker Sanix-Darker requested review from PrettyWood and fspot July 12, 2023 05:57
@Sanix-Darker
Copy link
Contributor

To bump on pydanticV2 (rust core) on our DS, we need to upgrade Weaverbird, but to upgrade Weaverbird, we need to upgrade toucan-connectors, and it also depends on Peakina!
So if this got merged and bumped, we might finally have pydanticv2 on our stack.

peakina/datasource.py Outdated Show resolved Hide resolved
@@ -23,7 +23,7 @@ chardet = ">=4,<6"
jq = "^1.2.1"
pandas = ">=1.5.3,<3.0.0"
paramiko = ">=2.9.2,<4.0.0"
pydantic = "^1.9.0"
pydantic = ">=1.9,<3.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we set the version to 2.0?

Suggested change
pydantic = ">=1.9,<3.0"
pydantic = ">=2.0,<3.0"

Copy link
Contributor

@Sanix-Darker Sanix-Darker Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @jGundermann !

As suggested by @PrettyWood , it could be great to support both !
That's why I made this : 3d3fa2f

And I setUpped the CI to check on py3.10/3.11 with both combinations pydantic 1/2 here too !
advantages : more confident on our delivery
disadvantages : long CI

Note: this is temporary, the day we will only support pydantic V2, we could fix that !

run: |
pip install -U pip poetry
# we update the pydantic version corresponding to the matrix
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml
Copy link
Contributor

@Sanix-Darker Sanix-Darker Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : i programmatically update the pyproject.toml file here on 'pydantic = ...' line for CI purposes

@Sanix-Darker Sanix-Darker requested a review from jGundermann July 12, 2023 09:40
Comment on lines +13 to +15
pydantic-version:
- "^1.10"
- "^2.0"
Copy link
Member

@PrettyWood PrettyWood Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the make lintisn't it a bit useless?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the job is called "lint" but we have a "mypy" checker on it... should we really remove it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it like that

peakina/datasource.py Outdated Show resolved Hide resolved
peakina/datasource.py Outdated Show resolved Hide resolved
@Sanix-Darker Sanix-Darker requested a review from PrettyWood July 12, 2023 12:15
@Sanix-Darker Sanix-Darker merged commit e9105ab into main Jul 13, 2023
@Sanix-Darker Sanix-Darker deleted the dependabot/pip/pydantic-2.0.2 branch July 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants