-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump pydantic from 1.10.9 to 2.0.2 #509
Conversation
9438e8a
to
3756778
Compare
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.9 to 2.0.2. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v1.10.9...v2.0.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3756778
to
91d46e1
Compare
__post_init_post_parse__ is no longer supported, and we can replace it with __post_init__ in our case.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 837 848 +11
=========================================
+ Hits 837 848 +11
☔ View full report in Codecov by Sentry. |
To bump on pydanticV2 (rust core) on our DS, we need to upgrade Weaverbird, but to upgrade Weaverbird, we need to upgrade toucan-connectors, and it also depends on Peakina! |
@@ -23,7 +23,7 @@ chardet = ">=4,<6" | |||
jq = "^1.2.1" | |||
pandas = ">=1.5.3,<3.0.0" | |||
paramiko = ">=2.9.2,<4.0.0" | |||
pydantic = "^1.9.0" | |||
pydantic = ">=1.9,<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we set the version to 2.0?
pydantic = ">=1.9,<3.0" | |
pydantic = ">=2.0,<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @jGundermann !
As suggested by @PrettyWood , it could be great to support both !
That's why I made this : 3d3fa2f
And I setUpped the CI to check on py3.10/3.11 with both combinations pydantic 1/2 here too !
advantages : more confident on our delivery
disadvantages : long CI
Note: this is temporary, the day we will only support pydantic V2, we could fix that !
run: | | ||
pip install -U pip poetry | ||
# we update the pydantic version corresponding to the matrix | ||
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note : i programmatically update the pyproject.toml file here on 'pydantic = ...' line for CI purposes
pydantic-version: | ||
- "^1.10" | ||
- "^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the make lint
isn't it a bit useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the job is called "lint" but we have a "mypy" checker on it... should we really remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it like that
Bumps pydantic from 1.10.9 to 2.0.2.
Release notes
Sourced from pydantic's releases.
... (truncated)
Changelog
Sourced from pydantic's changelog.
... (truncated)
Commits
00dc93f
Prepare for v2.0.2 (#6460)c3fc4e6
Fix pickling of RootModel (#6457)793c202
Allow single-item discriminated unions (#6405)c9292af
Fix issue with union parsing of enums (#6440)6bebd9c
Update pydantic-core to 2.1.2 (#6392)afdec31
💚 Fix git usage in FastAPI integration tests (#6434)3661981
👷 Require change files (#6428)88f2810
Docs: Fixing constr argument regex -> pattern // Typo (#6452)ca51901
Fix list indentation (#6408)ac61c07
Fix changelog link in pyproject.tomlDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)