Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump pydantic from 1.10.9 to 2.0.2 #509

Merged
merged 7 commits into from
Jul 13, 2023
Merged

build(deps): bump pydantic from 1.10.9 to 2.0.2 #509

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91d46e1
build(deps): bump pydantic from 1.10.9 to 2.0.2
dependabot[bot] Jul 12, 2023
833a373
feat: from the pydantic-2 documentation
Sanix-Darker Jul 12, 2023
3d3fa2f
feat: conditional post_ini based on pydantic version
Sanix-Darker Jul 12, 2023
c59f490
fix: another specificity from the migration
Sanix-Darker Jul 12, 2023
4fb8045
add support for pydantic 1 and 2 in the CI for lint and test
Sanix-Darker Jul 12, 2023
e09fe21
chore: update the CHANGELOG to get ready for a bump
Sanix-Darker Jul 12, 2023
40c3286
feat: update from PR review
Sanix-Darker Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,35 @@ jobs:
python-version:
- "3.10"
- "3.11"
pydantic-version:
- "^1.10"
- "^2.0"
Comment on lines +13 to +15
Copy link
Member

@PrettyWood PrettyWood Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the make lintisn't it a bit useless?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the job is called "lint" but we have a "mypy" checker on it... should we really remove it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it like that


steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: install_system_deps
run: sudo make install_system_deps

- name: Update Pydantic version on the toml & lock
run: |
pip install -U pip poetry
# we update the pydantic version corresponding to the matrix
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml
Copy link
Contributor

@Sanix-Darker Sanix-Darker Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : i programmatically update the pyproject.toml file here on 'pydantic = ...' line for CI purposes

poetry lock --no-update
env:
PYDANTIC_VERSION: ${{ matrix.pydantic-version }}

- name: install
run: make install

- name: lint
run: make lint

- name: mypy
run: make mypy

Expand All @@ -32,19 +49,37 @@ jobs:
python-version:
- "3.10"
- "3.11"
pydantic-version:
- "^1.10"
- "^2.0"

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: install_system_deps
run: sudo make install_system_deps

- name: Update Pydantic version on the toml & lock
run: |
pip install -U pip poetry
# we update the pydantic version corresponding to the matrix
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml
poetry lock --no-update
env:
PYDANTIC_VERSION: ${{ matrix.pydantic-version }}

- name: install
run: make install

- name: test
run: make test
env:
FTP_PATH: ${{ secrets.FTP_PATH }}
PYDANTIC_VERSION: ${{ matrix.pydantic-version }}

- name: Upload coverage
uses: codecov/codecov-action@v3