Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause flag {p}, include next flag {n}, undo flag {u} and more #50

Closed
wants to merge 22 commits into from

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Apr 9, 2020

  • Add pause flag {p} which allows you to let AutoSplit pause the timer
  • Add include next flag {n} which allows you to have multiple different split images that are compared simultaneously
  • Add undo flag {u} which allows you to control which split image in an image group should be chosen when you press undo in the group after that
  • Fix settings.pkl not loading
  • Add SplitImage class which makes code easier to read
  • Grouping splits is now compatible with @@ loops
  • Add requirements.txt to make getting the dependencies easier using pip
  • Add start image using the keyword start_auto_splitter that supports a custom comparison frequency (using <>)
  • Add support for a LiveSplit integration
  • Add a "Pause Comparison" button
  • Remove custom threshold/pause time checkboxes

Todo:

  • Testing
  • More filename examples in readme

kadiwa4 added 12 commits April 9, 2020 12:31
-Add SplitImage class which makes a lot of code a lot less complicated
-Make settings.pkl code shorter
-Add include next flag {n}
-Add undo flag {u}
-Group dummy splits is now compatible with loops
-Add disclaimer about complexity of the two new flags
-A ton of other stuff
@kadiwa4 kadiwa4 changed the title Add pause hotkey setting and pause flag {p} Add and pause flag {p}, include next flag {n} and undo flag {u} Apr 23, 2020
@kadiwa4 kadiwa4 changed the title Add and pause flag {p}, include next flag {n} and undo flag {u} Add pause flag {p}, include next flag {n}, undo flag {u} and more May 14, 2020
@Avasam
Copy link
Collaborator

Avasam commented Sep 5, 2020

@kadiwa4 There seems to be a critical bug with @loops@ that causes AutoSplit to never unpause.
To replicate, just have a split (let's say 003_Jungle_&_Altar_@3@_{md}, this is exactly how my file is named).
Once the autosplitter goes from split 002... to that one, it never unpauses.

@Avasam Avasam mentioned this pull request May 8, 2021
@Avasam Avasam mentioned this pull request Sep 30, 2021
@Avasam Avasam mentioned this pull request Nov 10, 2021
@Avasam
Copy link
Collaborator

Avasam commented Nov 10, 2021

I think this PR is enough out of date now that we can just close. Most of the features have either already been integrated, or are in the process of. If there's any more features we wanted from KaDiWa's version, let's create an issue (Feature Request) for it.

@kadiwa4
Copy link
Contributor Author

kadiwa4 commented Nov 11, 2021

@Avasam Thanks for putting in so much effort! It's great to see that this project is evolving, although I won't continue working on it, so I will close this.

@kadiwa4 kadiwa4 closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants