Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livesplit integration #60

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Livesplit integration #60

merged 3 commits into from
Nov 10, 2021

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 23, 2021

This extracts @kadiwa4 's work from PR #50 to implement LiveSplit integration.
This feature works using @kadiwa4 's AutoSplit Integration LiveSplit component.

Other than some IDE configurations I've added, all changes are directly related to this one feature. There isn't even automated linting fixes, which, if I do, will be in a different PR.

@Avasam
Copy link
Collaborator Author

Avasam commented Apr 23, 2021

There's just one issue. about.py clearly states that it's autogenerated code. But I'd like if there was a single source of truth for the version number.
Where and how is about.py generated exactly?

@kadiwa4
Copy link
Contributor

kadiwa4 commented Apr 23, 2021

I think about.py is generated with PyQt from res/about.ui.

It would be better to put the VERSION thing somewhere else where it still gets updated on startup.

@Avasam Avasam force-pushed the livesplit-integration branch from e016427 to cef9e08 Compare April 27, 2021 16:25
@Avasam Avasam marked this pull request as draft April 27, 2021 16:42
Single Source of truth for version number
@Avasam Avasam force-pushed the livesplit-integration branch from cef9e08 to 8079ac8 Compare April 27, 2021 16:44
@Avasam
Copy link
Collaborator Author

Avasam commented Apr 27, 2021

Version number now has a single source of truth in a location that won't get overridden by regenerating code.
Ready for review.

@Avasam Avasam marked this pull request as ready for review April 27, 2021 16:45
@Avasam Avasam force-pushed the livesplit-integration branch from 3b858cd to 2c403b3 Compare April 29, 2021 21:37
@Avasam
Copy link
Collaborator Author

Avasam commented Apr 29, 2021

In the mean time, I figured out a much better way to "kill" from dev console. And made the LiveSplit Exit more graceful.

@Avasam
Copy link
Collaborator Author

Avasam commented Aug 15, 2021

I don't remember whom I discussed this with, but we should be able to communicate with LiveSplit Server. Dropping dependency to KaDiWa4/LiveSplit.AutoSplitIntegration (a LiveSplit component could still be useful just to automatically start/kill LiveSplit, but would be optional)

@Avasam
Copy link
Collaborator Author

Avasam commented Sep 29, 2021

After looking more into it. Using the livesplit server is a bad idea. We can't listen to livesplit events (only send commands) and teh server has to be manually started by the user everytime. So this is still the best solution, unless we decide to package AutoSplit itself as a LiveSplit component (which could also benefit from autoupdates and UI cleanup)

@Toufool Toufool changed the base branch from master to dev November 10, 2021 01:45
@Toufool Toufool merged commit 7fa3609 into Toufool:dev Nov 10, 2021
Toufool added a commit that referenced this pull request Nov 10, 2021
Toufool added a commit that referenced this pull request Nov 10, 2021
@Avasam Avasam mentioned this pull request Nov 10, 2021
@Avasam Avasam deleted the livesplit-integration branch November 27, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants