-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livesplit integration #60
Conversation
There's just one issue. |
I think It would be better to put the |
e016427
to
cef9e08
Compare
Single Source of truth for version number
cef9e08
to
8079ac8
Compare
Version number now has a single source of truth in a location that won't get overridden by regenerating code. |
Also added the icon to the build command
3b858cd
to
2c403b3
Compare
In the mean time, I figured out a much better way to "kill" from dev console. And made the LiveSplit Exit more graceful. |
I don't remember whom I discussed this with, but we should be able to communicate with LiveSplit Server. Dropping dependency to KaDiWa4/LiveSplit.AutoSplitIntegration (a LiveSplit component could still be useful just to automatically start/kill LiveSplit, but would be optional) |
After looking more into it. Using the livesplit server is a bad idea. We can't listen to livesplit events (only send commands) and teh server has to be manually started by the user everytime. So this is still the best solution, unless we decide to package AutoSplit itself as a LiveSplit component (which could also benefit from autoupdates and UI cleanup) |
This extracts @kadiwa4 's work from PR #50 to implement LiveSplit integration.
This feature works using @kadiwa4 's AutoSplit Integration LiveSplit component.
Other than some IDE configurations I've added, all changes are directly related to this one feature. There isn't even automated linting fixes, which, if I do, will be in a different PR.