Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Move github actions dockerfile and dockercompose to /infrastructure/ folder #72

Closed
TreyWW opened this issue Sep 30, 2023 · 8 comments
Assignees
Labels
bug enhance Add on to an existing feature; or add something that isnt a new feature for example a test case help-wanted priority: medium

Comments

@TreyWW
Copy link
Owner

TreyWW commented Sep 30, 2023

I managed to get Actions working in root, so docker-compose.ci.yml now works, as its in the same directory as requirements.txt. But I do want to move it back to infrastructure/docker/

Anyone able to help with these, leave a comment and we can talk more

@TreyWW TreyWW added area: docker bug enhance Add on to an existing feature; or add something that isnt a new feature for example a test case help-wanted labels Sep 30, 2023
@TreyWW TreyWW pinned this issue Oct 1, 2023
@TreyWW TreyWW changed the title [BUG] Github Actions move to infrastructure [BUG] Github Actions move to /infrastructure/ folder Oct 4, 2023
@TreyWW TreyWW changed the title [BUG] Github Actions move to /infrastructure/ folder [BUG] Move github actions dockerfile and dockercompose to /infrastructure/ folder Oct 12, 2023
@daavo03
Copy link

daavo03 commented Oct 18, 2023

Hi there i'd like to give it a shot

@TreyWW
Copy link
Owner Author

TreyWW commented Oct 18, 2023

Sure thing! Really appreciate your interest. You've been assigned

@TreyWW
Copy link
Owner Author

TreyWW commented Oct 24, 2023

Hi there i'd like to give it a shot

Hi @daavo03, any progress? Need any help?

@HessTaha
Copy link
Contributor

Hi @TreyWW, can I contribute on this issue?

@TreyWW
Copy link
Owner Author

TreyWW commented Nov 14, 2023

Hi, yeah that sounds good. To be fair our whole docker setup is kinda strange and needs revamping I'd say. But yeah this issue is just to move dockerfile into infra/docker. It's a pain to get working and I gave up trying so if you can manage to get it working that would be much appreciated

@HessTaha
Copy link
Contributor

yes I'll give it a try !
And see afterward for docker step revamp

@TreyWW TreyWW assigned HessTaha and unassigned daavo03 Nov 15, 2023
@TreyWW TreyWW moved this to Bugs in MyFinances Project Nov 25, 2023
@HessTaha
Copy link
Contributor

HessTaha commented Dec 2, 2023

Hey, after some testing it appears a bit complicated to make it work as it is. Here are some proposals:

  1. Move the files to the infrastructure/backend, and add a "copy" step to the test workflow. The idea is to copy at least the docker-compose file to the root.
  2. Move only the Dockerfile and leave the docker-compose files at the root of the project.
    What do you think ?

Links:
1 || 2

@TreyWW
Copy link
Owner Author

TreyWW commented Dec 2, 2023

Hey @HessTah, thanks for your research, much appreciated.

Option 1 sounds like a great option. It's a bit of a shame that we'd need to use docker-compose -f infrastructure/backend/ on every docker command. We may need to look into how others do it cause 3-4 extra files in root is quite extreme so there must be projects where they've moved it to a file but don't have to use -f on every command.

Something to look into anyways,

Thanks for the options though, 1 sounds good

TreyWW added a commit that referenced this issue Dec 6, 2023
#72 | Bug: Add cp step for github action docker file / compose
@TreyWW TreyWW closed this as completed Dec 13, 2023
@github-project-automation github-project-automation bot moved this from Bugs to ✔ Done in MyFinances Project Dec 13, 2023
@TreyWW TreyWW unpinned this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhance Add on to an existing feature; or add something that isnt a new feature for example a test case help-wanted priority: medium
Projects
Archived in project
Development

No branches or pull requests

3 participants