🐛 Mongoose ReferenceQueryService only accepted Relations with ObjectIds #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 62a15d2.
☁️ Nx Cloud last updated this comment at |
simnado
force-pushed
the
bugfix/mongoose-query-service-accept-any-ids
branch
from
62a15d2 to
b364870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a hard limitation in
ReferenceQueryServicethat can only handle Relations/UnpagedRelations when the id fields are of typeObjectId. Since you can make relations with all kinds of field types in mongoose, nestjs-query should also support it.