Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mongoose ReferenceQueryService only accepted Relations with ObjectIds #340

Merged
merged 3 commits into from
Jan 13, 2025
Merged

🐛 Mongoose ReferenceQueryService only accepted Relations with ObjectIds #340

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b364870
fix: Mongoose ReferenceQueryService only accepted Relations with Obje…
simnado Dec 19, 2024
a556963
Merge branch 'master' into bugfix/mongoose-query-service-accept-any-ids
simnado Jan 5, 2025
58e3e1f
Merge branch 'master' into bugfix/mongoose-query-service-accept-any-ids
simnado Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/query-mongoose/src/services/reference-query.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ export abstract class ReferenceQueryService<Entity extends Document> {
const refs = entityRelations.filter((er) => {
return referenceIds.some((rid) => {
const oneOrManyIds = er[refFieldMap.foreignField as keyof Relation]
const ids = (Array.isArray(oneOrManyIds) ? oneOrManyIds : [oneOrManyIds]) as Types.ObjectId[]
return ids.some((id) => id.equals(rid as Types.ObjectId))
const ids = Array.isArray(oneOrManyIds) ? oneOrManyIds : [oneOrManyIds]
return ids.some((id) => String(id) === String(rid))
})
})
results.set(dto, await assembler.convertToDTOs(refs))
Expand Down