Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peers are being dropped when running Tribler on Windows #5485

Closed
devos50 opened this issue Jul 17, 2020 · 9 comments
Closed

Peers are being dropped when running Tribler on Windows #5485

devos50 opened this issue Jul 17, 2020 · 9 comments

Comments

@devos50
Copy link
Contributor

devos50 commented Jul 17, 2020

After our upgrade to Python 3.8, it seems that shortly after starting Tribler, peers are being dropped. The debug panel shows a few peers, but after a few minutes, these peers are gone. Anonymous downloads/TrustChain introduction requests are failing after around one minute.

Observations:

  • This happens both when running Tribler from source on our Windows building machine as well as running it from a frozen environment.
  • I have seen it both on 32-bit and 64-bit.
@devos50
Copy link
Contributor Author

devos50 commented Jul 18, 2020

After some extensive testing, it seems to occur when the ProactorEventLoop is used, which is the default loop in Python 3.8. I would suggest to fallback to the SelectorEventLoop for now, until we debugged/investigated the bug further.

@devos50 devos50 mentioned this issue Jul 18, 2020
@egbertbouman
Copy link
Member

Nice, good to hear my tip seems to have worked!

@ichorid
Copy link
Contributor

ichorid commented Jul 18, 2020

🤦 🤕

@egbertbouman
Copy link
Member

egbertbouman commented Jul 18, 2020

UDP support was only added recently to ProactorEventLoop (see https://bugs.python.org/issue29883), so maybe there are still some issues with it?

@qstokkink
Copy link
Contributor

I would suggest to fallback to the SelectorEventLoop for now, until we debugged/investigated the bug further.

The only downside I see to using the SelectorEventLoop is that it does not support Windows pipes (which we don't use) and doesn't use Windows IOCP, which is a bit better for multicore event handling.

I'd vote for just using SelectorEventLoop for the foreseeable future, without further debugging/investigating the ProactorEventLoop.

@ichorid
Copy link
Contributor

ichorid commented Jul 18, 2020

Reopened #5435. That's the downside.

@qstokkink
Copy link
Contributor

Ok, in that case I guess it's still worth it to try and get the ProactorEventLoop up and running.

@devos50
Copy link
Contributor Author

devos50 commented Jul 19, 2020

Given that the SelectorEventLoop seems to still work, I do not consider this as a blocker for the 7.5.2 release anymore.

@ichorid
Copy link
Contributor

ichorid commented Oct 6, 2021

Haven't seen this in awhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants