Use the default event loop on Windows #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the status after one hour of running this branch from installation on Windows, perfectly stable (reminder: #5485 noted that installations on Windows had unstable/disappearing peers):
I haven't seen any of the symptoms described in #5485 occur. I'll consider it solved by our code upgrades (or Python subversion upgrades) over the years. |
qstokkink
requested review from
a team and
drew2a
and removed request for
a team
qstokkink
changed the title
drew2a
approved these changes
Nov 8, 2023
qstokkink
changed the title
kozlovsky
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit ebabda8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5435 by removing the workaround for #5485.
Note that I will use the branch of this PR to make sure #5485 remains resolved. To that end, this PR may be amended with fixes related to #5485. I'll keep running a custom build for this PR (https://jenkins-ci.tribler.org/job/pers/job/Build-Win64-Custom/2/) for about an hour and keep an eye on the peers. If #5485 still does not appear, I will consider it resolved.