Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove memoization of AIR constraints #121

Closed
jan-ferdinand opened this issue Nov 14, 2022 · 0 comments · Fixed by #125
Closed

remove memoization of AIR constraints #121

jan-ferdinand opened this issue Nov 14, 2022 · 0 comments · Fixed by #125
Labels
🤖 code Changes the implementation 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent ⏩ speedup Makes stuff go faster.

Comments

@jan-ferdinand
Copy link
Member

Evaluating AIR constraints using rust code is a lot faster compared to using multivariate polynomials. Once all constraints are expressed as code, i.e., after PR #117 is merged and the relevant parts of #115 are complete, remove the memoization of constraint polynomials that is currently happening in most table's extend method.
@jan-ferdinand jan-ferdinand added 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent 🤖 code Changes the implementation ⏩ speedup Makes stuff go faster. labels Nov 14, 2022
@jan-ferdinand jan-ferdinand linked a pull request Nov 20, 2022 that will close this issue
Bypass MPolynomial Representation of AIR Constraints #125
Merged
jan-ferdinand added a commit that referenced this issue Nov 20, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
096c631 
fix #121
@jan-ferdinand jan-ferdinand mentioned this issue Nov 20, 2022
Merged
jan-ferdinand added a commit that referenced this issue Nov 20, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
675cb04 
fix #121
jan-ferdinand added a commit that referenced this issue Nov 20, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
4df8691 
fix #121
jan-ferdinand added a commit that referenced this issue Nov 21, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
88fa26e 
fix #121
jan-ferdinand added a commit that referenced this issue Nov 21, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
db92ce0 
fix #121
jan-ferdinand added a commit that referenced this issue Nov 21, 2022
@jan-ferdinand
remove memoization of AIR constraints and degree bounds
a491ffe 
fix #121
sshine pushed a commit that referenced this issue Nov 21, 2022
@jan-ferdinand @sshine
remove memoization of AIR constraints and degree bounds
501ffc2 
fix #121
jan-ferdinand added a commit that referenced this issue Nov 21, 2022
@jan-ferdinand
Bypass MPolynomial Representation of AIR Constraints (#125)
5434e2f 
- express all constraints of all tables as arithmetic circuits
- generate code to evaluate those constraints
- generate code for getting quotient degree bounds
- remove memoization of AIR constraints & degree bounds
- automatically perform code generation on running `make test`
→ completely remove multivariate polynomials from tables

fix #96, fix #121, fix #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 code Changes the implementation 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent ⏩ speedup Makes stuff go faster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bypass MPolynomial Representation of AIR Constraints TritonVM/triton-vm
1 participant
@jan-ferdinand