Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass MPolynomial Representation of AIR Constraints #125

Merged
merged 27 commits into from
Nov 21, 2022
Merged

Bypass MPolynomial Representation of AIR Constraints #125

merged 27 commits into from
Nov 21, 2022

Conversation

jan-ferdinand
Copy link
Member

@jan-ferdinand jan-ferdinand commented Nov 15, 2022 •
edited
Loading

Summary:

  • express all constraints of all tables as arithmetic circuits
  • generate code to evaluate those constraints
  • generate code for getting quotient degree bounds
  • remove memoization of AIR constraints & degree bounds
  • $\Rightarrow$ completely remove multivariate polynomials from tables

Running cargo criterion --bench prove_fib_100 on this PR's branch comparing to current master:

Fix #96, #121, #123

@jan-ferdinand jan-ferdinand linked an issue Nov 15, 2022 that may be closed by this pull request
Bypass MPolynomial Representation of AIR Constraints #96
Closed
4 tasks
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 4 times, most recently from a37f598 to ddf060d Compare November 16, 2022 07:55
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 2 times, most recently from 74207ae to 825f36e Compare November 16, 2022 22:45
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 2 times, most recently from 97d9ffd to f8f6569 Compare November 17, 2022 18:56
Base automatically changed from arithmetic_domain to master November 18, 2022 11:50
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 4 times, most recently from f3086dd to cf29f12 Compare November 20, 2022 19:16
This was linked to issues Nov 20, 2022
remove memoization of AIR constraints #121
Closed
compute degree bounds from circuits instead of from multivariate polynomials #123
Closed
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 2 times, most recently from f379c5a to ddcea96 Compare November 20, 2022 23:10
@jan-ferdinand jan-ferdinand marked this pull request as ready for review November 20, 2022 23:11
@jan-ferdinand jan-ferdinand force-pushed the circuits_everywhere branch 2 times, most recently from fa553b4 to d3f96b0 Compare November 21, 2022 06:14
jan-ferdinand and others added 20 commits November 21, 2022 16:20
@jan-ferdinand @sshine
op_stack: {initial, consistency, terminal} constraints as circuits
ea2c68b 
(#115)
@jan-ferdinand @sshine
ram: {initial, consistency, terminal} constraints as circuits
5a5208a 
(#115)
@jan-ferdinand @sshine
jump_stack: {initial, consistency, terminal} constraints as circuits
21fde2b 
(#115)
@jan-ferdinand @sshine
hash: {initial, terminal} constraints as circuits
16bec50 
(#115)
@jan-ferdinand @sshine
hash: consistency constraints as circuits
92e1727
@jan-ferdinand @sshine
factor out method to turn circuits into string
54257ff
@jan-ferdinand @sshine
construct initial constraints as circuits
0421a00
@jan-ferdinand @sshine
generate code to implement trait Quotientable (#123)
2a8d7d7
@jan-ferdinand @sshine
hash: transition constraints as circuits
d34a0e5 
(#123, #115, #96)
@jan-ferdinand @sshine
auto-generate code for consistency constraints & quotients
babd223 
(#123, #115, #96)
@jan-ferdinand @sshine
auto-generate code for terminal constraints & quotients
bc98e74 
(#123, #115, #96)
@jan-ferdinand @sshine
remove memoization of AIR constraints and degree bounds
501ffc2 
fix #121
@jan-ferdinand @sshine
avoid use of MPolynomial for AIR constraints completely
f73ac70
@jan-ferdinand @sshine
slightly improve imports and method to_vec()
d8f96f2
@jan-ferdinand @sshine
simplify match using if let and matches!, simplify qualifications
c4f155c
@jan-ferdinand @sshine
update CI
64502d6 
Co-authored-by: sshine <simon@neptune.cash>
@jan-ferdinand @sshine
simplify code-template for table's constraints
426c206
@jan-ferdinand @Sword-Smith @sshine
add comments and clarify some method's names
a1f8a88 
Co-authored-by: sword-smith <thor@neptune.cash>
@jan-ferdinand @sshine
remove dependency on “heck” and build snake & camel case locally
bd3a8dd
@jan-ferdinand @sshine
remove obsolete trait methods for computing degree bounds
f79e1bd
@sshine sshine force-pushed the circuits_everywhere branch from aba373f to f79e1bd Compare November 21, 2022 15:20
aszepieniec
aszepieniec requested changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@aszepieniec aszepieniec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Requested changes:

  • build script that automatically generates constraints code when not already present
  • don't spam terminal when generating code
  • test suite should work out of the box

sshine
sshine approved these changes Nov 21, 2022
View reviewed changes
triton-vm/src/table/extension_table.rs Outdated Show resolved Hide resolved
triton-vm/src/table/extension_table.rs Outdated Show resolved Hide resolved
triton-vm/src/table/extension_table.rs Outdated Show resolved Hide resolved
triton-vm/src/table/extension_table.rs Outdated Show resolved Hide resolved
jan-ferdinand and others added 4 commits November 21, 2022 17:33
@jan-ferdinand @sshine
remove superfluous environment variable
17a99c8 
Co-authored-by: sshine <simon@neptune.cash>
@sshine
Create Makefile, use Makefile in CI
0420ee0 
The main purpose of creating a Makefile is to be able to generate
constraints before running `cargo`. Doing this in a build.rs script
proves to be a little circular.

Since a Makefile is introduced, we make the CI script depend on it to
ensure consistency.
@sshine
Bump triton-profiler to use twenty-first-0.6.0
d1b78b5
@jan-ferdinand
add stress test
7a5350e
@jan-ferdinand jan-ferdinand merged commit 5434e2f into master Nov 21, 2022
@jan-ferdinand jan-ferdinand deleted the circuits_everywhere branch November 21, 2022 20:09
sshine added a commit that referenced this pull request Nov 22, 2022
@sshine
Increase version to 0.7.0
c3a7f1c 
The main advancement of this release is the use of performance-optimized
arithmetic circuits instead of multivariate polynomials for expressing
constraints. (cd62c59)

- Depend on twenty-first-0.7.0
- Don't multiply randomizer codeword by random weight (#139)
- Replace `Replace `Result<T, Box<dyn Error>>` with `anyhow::Result<T>`) (#134)
- Use quotient domain instead of FRI domain wherever applicable (#114)
- Fix bug in the decoding procedure for `Vec<PartialAuthenticationPath>` (e7fd6cc)
- Run 'cargo fmt' after constraint-evaluation-generator (2d183e4)
- Add prove_fib_100 benchmark for STARK proving (1326b12)
- Replace TimingReporter with TritonProfiler (c40c1bc)
- Add "TIP 0004: Drop U32 Table"
- Drop `VecStream` in favor of `Vec<BFieldElement>`

PR #125:
- Generate all constraints as circuits
- Remove memoization of AIR constraints
- Bypass MPolynomial Representation of AIR Constraints
- Create Makefile, use Makefile in CI
- Auto-generate Quotientable trait instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszepieniec aszepieniec aszepieniec requested changes

@sshine sshine sshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jan-ferdinand @sshine @aszepieniec @Sword-Smith