-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master Tables #144
Merged
Merged
Master Tables #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make derivation of “local” table column's index nicer - remove unused `Bounded` trait - write (and rewrite) test cases for column index consistency checking
- make them static, not object-bound - use master tables in cross table arguments Sometimes, you just have to change everything at once.
- compute the combination codeword in a more parallel and type-safe way - use only padded_height, not ext_table_collection, in cross table args - parallelize point-wise operation - replace `i64` with `Degree` throughout the project
jan-ferdinand
force-pushed
the
master_of_tables
branch
from
December 2, 2022 10:47
09dfae0
to
6f223ec
Compare
This makes it convenient to re-use the constraint type's respective zerofiers, instead of computing them once per table.
- properly write cross-table arg's quotient to master quotient table - more & improved documentation - a little less lifting of `BFieldElements`s
jan-ferdinand
force-pushed
the
master_of_tables
branch
from
December 5, 2022 10:31
333ee37
to
792cc42
Compare
jan-ferdinand
force-pushed
the
master_of_tables
branch
from
December 5, 2022 14:40
792cc42
to
98dccfa
Compare
jan-ferdinand
force-pushed
the
master_of_tables
branch
from
December 5, 2022 14:43
98dccfa
to
ac5e01f
Compare
- make fields of `Stark` public - tests use `MasterBaseTable` and `MasterExtTable` - remove some tests that don't make sense anymore
Allows them to be expressed in the extension field directly, making re-assembly of the individual coefficients superfluous. Incidentally also gives rise to simpler master table indexing.
sshine
reviewed
Dec 19, 2022
Makes computing the inner product about 4 times faster.
This is only a small speedup in rust. However, it is probably a good preparation for the recursive verifier.
jan-ferdinand
added a commit
that referenced
this pull request
Dec 22, 2022
jan-ferdinand
added a commit
that referenced
this pull request
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Master Table is, in some sense, a top-level table of Triton VM. It contains all the data but little logic beyond bookkeeping and presenting the data in a useful way. Conversely, the individual tables contain no data but all of the respective logic. Master Tables are responsible for managing the individual tables and for presenting the right data to the right tables, serving as a clean interface between the VM and the individual tables.
As a mental model, it is perfectly fine to think of the data for the individual tables as completely separate from each other. Only the cross-table argument links all tables together.
Conceptually, there are three Master Tables: the Master Base Table, the Master Extension Table, and the Master Quotient Table. The lifecycle of the Master Tables is as follows:
The following points are of note:
necessary for zero-knowledge.
is also stored in the Master Quotient Table. Even though the cross-table argument is not
a table, it does define part of the AIR. Hence, the cross-table argument does not contribute
to padding or extending the Master Tables, but is incorporated when deriving the Master
Qoutient Table.
Master Base Table and Master Extension Table over a smaller domain than the FRI domain –
the “quotient domain.” The quotient domain is a subset of the FRI domain. This
performance improvement changes nothing conceptually.
GrandCrossTableArg
as a first-class citizen#[repr(usize)]
for*Table*Column
to safely allow indexing with compile-time known indicesramp
, which is unenforceable anywayFix #11, fix #119, fix #120, fix #139, fix #148, fix #155.