Code

Master Tables#144

Code

Merged

jan-ferdinand merged 140 commits intomasterTritonVM/triton-vm:masterfrom master_of_tablesTritonVM/triton-vm:master_of_tablesCopy head branch name to clipboardDec 20, 2022

+8,389-7,638

Commits

Commits on Nov 25, 2022

• introduce master table, get some basic features down (WIP)

  jan-ferdinand

  committed
  7053a67

Commits on Nov 26, 2022

• incorporate randomizer polynomial, FRI domain base master table (WIP)

  jan-ferdinand

  committed
  a27003a

• derive ”Copy“ for ArithmeticDomain

  jan-ferdinand

  committed
  0e9a6b7

• factor out filling in trace of program table

  jan-ferdinand

  committed
  759ba44

Commits on Nov 27, 2022

• extend program table, move padding logic to program table

  jan-ferdinand

  committed
  e721f47

• make trace randomization more explicit

  jan-ferdinand

  committed
  521f574

• derive some derivable consts instead of hardcoding them

  jan-ferdinand

  committed
  4b2a6dd

• create trait MasterTable, factor out trace randomization & LDE

  jan-ferdinand

  committed
  ec81c44

Commits on Nov 28, 2022

• derive master-table indices from table columns

  Show description for 8457e90
  jan-ferdinand

  committed
  8457e90

• remove a bunch of legacy code

  jan-ferdinand

  committed
  0f1e953

Commits on Nov 30, 2022

• change traits for getting degree bounds and quotients

  Show description for f3ddbe1
  jan-ferdinand

  committed
  f3ddbe1

Commits on Dec 2, 2022

• introduce “master quotient table”: store quotients in an Array2

  Show description for 6f223ec
  jan-ferdinand

  committed
  6f223ec

• start treating grand cross-table argument as a first-class quotient

  jan-ferdinand

  committed
  35086aa

• actually return the quotients – sorted by type, not table

  Show description for e4d5df1
  jan-ferdinand

  committed
  e4d5df1

Commits on Dec 3, 2022

• use ndarray, not vectors, in cross-table arguments

  Show description for ed49d57
  jan-ferdinand

  committed
  ed49d57

• remove some cloning and explicit type annotations

  jan-ferdinand

  committed
  bf3ed3e

Commits on Dec 5, 2022

• fill trace of Instruction Table

  jan-ferdinand

  committed
  8536afa

• fill trace of Op Stack Table

  jan-ferdinand

  committed
  7b06aaa

• fill trace of Jump Stack Table

  jan-ferdinand

  committed
  97d1438

• fill trace of Ram Table

  jan-ferdinand

  committed
  ac5e01f

• fill trace of Processor Table

  jan-ferdinand

  committed
  abae0c3

• fill trace of Hash Table

  jan-ferdinand

  committed
  10808c9

• remove BaseMatrices, BaseTableCollection, and ExtTableCollection

  Show description for f9fedc6
  jan-ferdinand

  committed
  f9fedc6

• move randomizer polynomials from master base to master extension table

  Show description for d20ab7b
  jan-ferdinand

  committed
  d20ab7b

• remove superfluous trait indirection

  jan-ferdinand

  committed
  499bd36

• refactor transition constraint test to actually use master tables

  jan-ferdinand

  committed
  c544aee

• remove obsolete extend method in Program Table

  jan-ferdinand

  committed
  48d9d75

• remove obsolete dummy constructors for_verifier

  jan-ferdinand

  committed
  4f72a6a

• remove obsolete impl Default for Ext*Table

  jan-ferdinand

  committed
  90f6d01

Commits on Dec 6, 2022

• pad Instruction Table in-place

  jan-ferdinand

  committed
  bc29366

• pad Processor Table in-place

  jan-ferdinand

  committed
  0810cd0

• fix bug in verifier: randomizer codeword it at end of ext master table

  jan-ferdinand

  committed
  528698e

• make constraint circuits work with master table

  Show description for 1962dd2
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  1962dd2

Commits on Dec 7, 2022

• remove somewhat confusing in-place modification, turn into return value

  jan-ferdinand

  committed
  b6fce7a

• generate constraints that use the master tables

  jan-ferdinand

  committed
  aee6ded

• test consistency of InputIndicator's from() and into()

  jan-ferdinand

  committed
  4bb2e46

• remove superfluous thin wrapper around usize

  jan-ferdinand

  committed
  59e0890

• use master table index throughout

  jan-ferdinand

  committed
  ec9d6a0

• remove confusing conversion from usize to InputIndicators

  Show description for ca18c06
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  ca18c06

• remove multivariate polynomials from multicircuits

  jan-ferdinand

  committed
  54694d0

Commits on Dec 8, 2022

• pad Op Stack Table in-place

  jan-ferdinand

  committed
  6963eec

• pad Jump Stack Table in-place

  jan-ferdinand

  committed
  6baf3d0

• pad Ram Table in-place

  jan-ferdinand

  committed
  72247e4

• “pad” Hash Table in-place

  jan-ferdinand

  committed
  815b9db

• remove traits Table, TableLike, InheritsFromTable, Extendable

  Show description for 882461e
  jan-ferdinand

  committed
  882461e

• move declaration of AET to vm.rs, printing methods next to their tables

  jan-ferdinand

  committed
  b390a4e

Commits on Dec 9, 2022

• fix some out-of-bounds indexing during padding of memory-like tables

  jan-ferdinand

  committed
  944fb8c

• use correct columns for Ram Table's Bézout coefficients

  jan-ferdinand

  committed
  92cc7c0

• derive table column index at compile time

  jan-ferdinand

  committed
  5c5e30f

• use trace table, not randomized trace table, for certain tests

  jan-ferdinand

  committed
  10bb807

• check for correct number of extension columns instead of full width

  jan-ferdinand

  committed
  f7f200e

• use some line breaks in the crate's description

  jan-ferdinand

  committed
  b0df99b

• auto-generate number of quotients for less ugly & faster derivation

  jan-ferdinand

  committed
  ddca5d2

• use correct indices for filling master quotient table

  jan-ferdinand

  committed
  3054a42

Commits on Dec 10, 2022

• don't add randomizer polynomials to _weighted_ nonlinear combination

  jan-ferdinand

  committed
  ae77f82

• remove multivariate polynomials from multicircuits harder

  jan-ferdinand

  committed
  6448f66

• extend Instruction Table

  jan-ferdinand

  committed
  ecbe038

• de-duplicate some logic when extending Instruction Table

  jan-ferdinand

  committed
  5bf9375

• extend Processor Table

  jan-ferdinand

  committed
  a72921a

• use correct number of rows for master extension table

  jan-ferdinand

  committed
  8fbe1c9

• use master tables, not Processor Table, in test

  jan-ferdinand

  committed
  8a85e74

Commits on Dec 12, 2022

• actually pad the Processor Table according to specification

  jan-ferdinand

  committed
  f757301

• extend Op Stack Table

  jan-ferdinand

  committed
  3fcf9b2

• extend Ram Table

  jan-ferdinand

  committed
  7775cf8

• only bring extension row into scope just before it's needed

  jan-ferdinand

  committed
  7da1b79

• extend Jump Stack Table

  jan-ferdinand

  committed
  bc03e76

• extend Hash Table

  jan-ferdinand

  committed
  ffd8351

• use trace table, not randomized trace table, in tests

  jan-ferdinand

  committed
  f8d03ed

• add “test” to print & quickly match master table indices to columns

  jan-ferdinand

  committed
  66cd89c

• better code formatting and less confusing indices in error messages

  jan-ferdinand

  committed
  5cdba8f

• de-duplicate some test code

  jan-ferdinand

  committed
  6caf820

• remove obsolete row derivation methods

  jan-ferdinand

  committed
  896b273

• use the correct columns for Bézout coefficient polynomial's coefficients

  jan-ferdinand

  committed
  7d732cf

• add more extensive tests of all constraints

  jan-ferdinand

  committed
  33f4c39

• remove unenforceable constraints

  jan-ferdinand

  committed
  95e6728

• better readability of Ram Table transition constraints, fix bug therein

  jan-ferdinand

  committed
  6ff9bf0

• use quotient domain, not FRI domain, for debug degree checking

  Show description for 2b776d1
  jan-ferdinand

  committed
  2b776d1

• rename .master_table_index() to clarify between base & extension table

  jan-ferdinand

  committed
  59ac718

• use consistent naming for master_base_table

  jan-ferdinand

  committed
  8f962dd

• properly implement parallelized low-degree extension

  jan-ferdinand

  committed
  b8965cd

• replace difficult-to-read par_azip!() with Zip::from().and()

  jan-ferdinand

  committed
  1b6a935

Commits on Dec 13, 2022

• add property test performing random RAM read & write access

  jan-ferdinand

  committed
  2709af8

• improve error message for IP out of bounds

  jan-ferdinand

  committed
  097ebb4

• fix some buggy Ram Table constraints and add back some removed ones

  Show description for a92b9b8
  jan-ferdinand

  committed
  a92b9b8

• add column PreviousInstruction to Processor and Ram Table

  jan-ferdinand

  committed
  69e8bcb

• remove redundant tests

  jan-ferdinand

  committed
  256585a

Commits on Dec 14, 2022

• fix a bug in recording clock jump differences for the Processor Table

  jan-ferdinand

  committed
  cf437a8

• correctly accumulate Ram Table row in running product

  Show description for e6262c9
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  e6262c9

• correctly absorb entire Ram Table row in relevant initial constraint

  Show description for 95b5427
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  95b5427

• use “previous instruction next” not “current”

  Show description for f1927f7
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  f1927f7

Commits on Dec 15, 2022

• improve debug output for failing transition constraints in test

  jan-ferdinand

  committed
  eda591e

• improve property RAM access test to include reading uninitialized memory

  jan-ferdinand

  committed
  e9631e3

• add clarifying comment regarding the setting of “previous instruction”

  jan-ferdinand

  committed
  8b28689

• update the stack with the fetched RAM value when executing “read_mem”

  Show description for 0888203
  

  jan-ferdinand

  and

  aszepieniec

  committed
  0888203

• when debugging, use FRI domain to compute quotients and degree checking

  jan-ferdinand

  committed
  f14b658

• also test all constraints for the simplest possible program: “halt”

  jan-ferdinand

  committed
  41dcd78

• parallelize filling of quotient table

  jan-ferdinand

  committed
  a3e6481

• test correctness of zerofiers and make their method's interface cleaner

  Show description for 7e9ad82
  

  jan-ferdinand

  and

  Sword-Smith

  committed
  7e9ad82

• remove placeholder “padded_height = 0” from Claim – only claim truth

  jan-ferdinand

  committed
  0ddecc5

• improve readability of prover, add assert for AllChallenges weights

  Show description for e3e5243
  jan-ferdinand

  committed
  e3e5243

Commits on Dec 16, 2022

• remove unused traits ExtensionTable and QuotientableExtensionTable

  jan-ferdinand

  committed
  74712b7

• implement Evaluable and Quotientable for GrandCrossTableArgument

  jan-ferdinand

  committed
  18b0257

• make GrandCrossTableArg a master-table first-class citizen

  jan-ferdinand

  committed
  f4a4a91

• remove now-dead code in GrandCrossTableArg, PermArg, and EvalArg

  jan-ferdinand

  committed
  c34ca73

• move cross_table_argument.rs into folder table

  jan-ferdinand

  committed
  66be909

• use correct initial and terminal zerofiers in verifier

  jan-ferdinand

  committed
  ca627ce

• update spec: transition constraints for instruction divine_sibling

  jan-ferdinand

  committed
  6554202

• rename .table_index() to distinguish between base and extension tables

  jan-ferdinand

  committed
  e6d158e

• memoize, don't recompute interpolation_degree

  Show description for 6351324
  jan-ferdinand

  committed
  6351324

• simplify and parallelize padding of Instruction Table

  jan-ferdinand

  committed
  5cece86

• remove now-superfluous clippy exception

  jan-ferdinand

  committed
  99ad5de

• update spec: Ram Table does not have to be sorted by ramp

  jan-ferdinand

  committed
  a33e3e6

• add missing initial constraint to Ram Table

  jan-ferdinand

  committed
  f79f1d0

• add “test” to print an example interaction between Processor & Ram Table

  jan-ferdinand

  committed
  024e486

• update spec: new column “previous instruction” and its constraints

  jan-ferdinand

  committed
  9673977

• AET uses ndarrays

  jan-ferdinand

  committed
  b9a382c

• cleaner code flow for enriching a hash trace with constants for the AET

  jan-ferdinand

  committed
  292a708

• remove generator as argument to ArithmeticDomain, compute it instead

  jan-ferdinand

  committed
  889242a

• make clippy 1.66 happy

  jan-ferdinand

  committed
  5b66247

• rename table_collection.rs to master_table.rs

  jan-ferdinand

  committed
  efab08b

• update comment regarding cross-table terminal quotient being filled in

  jan-ferdinand

  committed
  385acd3

• read claimed padded height from correct position of the proof

  jan-ferdinand

  committed
  fb940b1

• more aptly name some proof-stream methods, remove unneeded ones

  jan-ferdinand

  committed
  5e19845

• less degree shifting, remove superfluous degree bound computations

  jan-ferdinand

  committed
  ea225a0

• remove in-line todo currently being discussed in the issue tracker

  jan-ferdinand

  committed
  abd307d

• add clarity to number of non-linear codeword checks

  jan-ferdinand

  committed
  c705b88

• docstring for an indexing method that might look weird but is kinda nice

  jan-ferdinand

  committed
  83f76b7

Commits on Dec 17, 2022

• add documentation for master tables

  jan-ferdinand

  committed
  ef4e70f

Commits on Dec 19, 2022

• add or rephrase some miscellaneous comments

  jan-ferdinand

  committed
  73254e7

• don't enforce underlying memory layout, use generic and safer methods

  jan-ferdinand

  committed
  1dc7d4d

• add profilers to tests that prove correctness of a program

  jan-ferdinand

  committed
  06bc2fd

• list number of constraints also for cross-table argument, profile malloc

  jan-ferdinand

  committed
  7808dfa

• store, don't recompute degree bounds in the verifier

  jan-ferdinand

  committed
  5b309f6

• use ndarray's multiplication instead of trying to be smart

  Show description for 87476bb
  jan-ferdinand

  committed
  87476bb

• memoize shifted FRI domain values in the verifier

  Show description for 8033a12
  jan-ferdinand

  committed
  8033a12

• describe verifier steps more accurately

  jan-ferdinand

  committed
  a5602c5

• over-engineer the crap out of degree-shifting FRI domain values

  jan-ferdinand

  committed
  5f8c4a3

Commits on Dec 20, 2022

• update cheatsheet

  jan-ferdinand

  committed
  fd70732

• cheatsheet: move tables to one page, create room for stack effects

  jan-ferdinand

  committed
  fc96a47

• cheatsheet: describe instructions' effects on stack

  jan-ferdinand

  committed
  78d2a78