Skip to content

Commit

Permalink
Revert "test: skip test-cpu-prof in debug builds with code cache"
Browse files Browse the repository at this point in the history
Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d.

Refs: nodejs#27423

PR-URL: nodejs#27469
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
addaleax authored and Trott committed May 1, 2019
1 parent e1c838e commit 5f68489
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/sequential/test-cpu-prof.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
// This tests that --cpu-prof, --cpu-prof-dir and --cpu-prof-name works.

const common = require('../common');
if (process.features.debug && process.features.cached_builtins) {
// FIXME(joyeecheung): the profiler crashes when code cache
// is enabled in debug builds.
common.skip('--cpu-prof does not work in debug builds with code cache');
}

const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();

Expand Down

0 comments on commit 5f68489

Please sign in to comment.