Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: skip test-cpu-prof in debug builds with code cache" #27469

Closed
wants to merge 1 commit into from
Closed

Revert "test: skip test-cpu-prof in debug builds with code cache" #27469

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d.

Refs: #27423

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
Revert "test: skip test-cpu-prof in debug builds with code cache"
f6747e2 
Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d.

Refs: nodejs#27423
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3385

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 29, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22793/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2019
@Trott
Copy link
Member

Trott commented May 1, 2019

Landed in 5f68489

@Trott Trott closed this May 1, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 1, 2019
@addaleax @Trott
Revert "test: skip test-cpu-prof in debug builds with code cache"
5f68489 
Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d.

Refs: nodejs#27423

PR-URL: nodejs#27469
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 4, 2019
@addaleax @targos
Revert "test: skip test-cpu-prof in debug builds with code cache"
33fead3 
Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d.

Refs: #27423

PR-URL: #27469
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @Trott @cjihrig @gengjiawen @joyeecheung