If a switch input is renamed when it is already selected, the combo value doesn't update

[chrisgoringe]

I renamed the slot, but the combo doesn't change

as a result,

[Trung0246]

Looks like I forgot about it.

[chrisgoringe]

Picked up in testing of https://github.com/chrisgoringe/cg-controller, because this was the most requested custom node to support!

…

On Mon, 25 Nov 2024 at 12:29, Trung0246 ***@***.***> wrote: Looks like I forgot about it. — Reply to this email directly, view it on GitHub <#46 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA4PI5DEQXRDKICYPFT2CJ4Q7AVCNFSM6AAAAABSMZNLOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGQ4TKOJUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JorgeR81]

Picked up in testing of https://github.com/chrisgoringe/cg-controller,
because this was the most requested custom node to support!

The Hub node also works great in the Controller !

They both complement each other, very well:

• The Hub allows the Controller to add individual widgets, independently from their nodes ( like InvokeAI ).
  We just need to add the widgets to the Hub node. And then add the Hub to the Controller !

• And the Controller allows to add Image nodes, next to the Hub, in the same Controller window / side panel.

---

There is also a visual issue in the Hub, where is text widget is not placed correctly ( #47 ).
But it still works correctly, when the Hub is added to the Controller, as you can see in the screenshot.

---

[JorgeR81]

The only feature I'm missing, it's the ability to hide the Hub's controls, once it's configured, because they waste a lot of space.

But I'm not sure about the best way to do this:

• Either @Trung0246 add this feature to the Hub node ( [ Feature ] Add option to hide the Hub controls. #29 )
• or @chrisgoringe adds a feature to hide the Hub buttons, in the Controller.

Ideally the Controller would use the "native" Hub node features.

But in this case, I guess the Controller needs this feature more, because it has a limited amount of free space in the screen.

[JorgeR81]

About the switch fix ( fad4ef5).

Now it updates, when I rename the ( first ) input.
But I can only rename the first input.
When try o rename other inputs, nothing happens, when click OK in the text pop-up.

When I press F12, I see the browser it's in debug mode.
It's Goggle Chrome.

---

[chrisgoringe]

• or @chrisgoringe adds a feature to hide the Hub buttons, in the Controller.

Ideally the Controller would use the "native" Hub node features.

But in this case, I guess the Controller needs this feature more, because it has a limited amount of free space in the screen.

This would be covered by the controller having the option to choose which widgets to display, right? Planned for v1.6...

[Trung0246]

Now it updates, when I rename the ( first ) input. But I can only rename the first input. When try o rename other inputs, nothing happens, when click OK in the text pop-up.

Hm weird this should works to my testing. What did you do?

[JorgeR81]

Hm weird this should works to my testing. What did you do?

I did some more testing.
It works in old workflows, when input names were changed already.
But it does not work, if the inputs have the original name, in a new switch.

---

[JorgeR81]

This would be covered by the controller having the option to choose which widgets to display, right? Planned for v1.6...

I'm not sure.

Will the Controller rely on the upcoming "advanced widgets" ComfyUI feature, to hide the widgets ?
Comfy-Org/litegraph.js#250

And will this ComfyUI feature, support hiding the Hub's buttons ?

If I convert the Hub's widgets to inputs, they don't show up in the Controller.
But we still can see the buttons, which take half the space ( and will be useless without their widgets ).

---

[chrisgoringe]

This would be covered by the controller having the option to choose which widgets to display, right? Planned for v1.6...

I'm not sure.

Will the Controller rely on the upcoming "advanced widgets" ComfyUI feature, to hide the widgets ? Comfy-Org/litegraph.js#250

no

And will this ComfyUI feature support hiding the Hub's buttons ?

yes (buttons are widgets)

But maybe we should take this conversation over to chrisgoringe/cg-controller#143 since it's not about 0246's switch

[JorgeR81]

I did some more testing.
It works in old workflows, when input names were changed already.
But it does not work, if the inputs have the original name, in a new switch.

@Trung0246, where you able replicate this ?

Perhaps it's better to revert the current fix, until you have a complete fix.
With the old bug, we have a workaround. We just need to select the option again.
But with the new bug, introduced by the fix, we can't rename new inputs.

[Trung0246]

Where you able replicate this ?

Unfortunately no. On my side it works correctly. I could add option to revert back to original behavior.

[JorgeR81]

On my side it works correctly.

Maybe this is related to my configuration.
I have:

• Windows 10 
• Portable install 
• pytorch version: 2.3.1+cu121

---

I could add option to revert back to original behavior.

Yes, that would work for me.
I don't mind the original behavior.

[JorgeR81]

I could add option to revert back to original behavior.

I tried the new option.
The old behavior is working fine for me.

[JorgeR81]

I've made some more tests with the new behavior.

I'm happy with the original behavior, but I will share my test results, in case it helps to get a better solution.

---

With the new behavior, I've found that I can change all the input names, if the switch has the same amount of outputs, like in the image below.

---

If the switch has no outputs, I can't change the name of any input.

---

If the switch has 1 output, I can't change the name of the first input.

---

If the switch has 2 outputs, I can't change the name of the first and second outputs.

---

If the switch has 3 outputs, I can change the names of all 3 inputs.

---

But if remove 1 output, I can't change the name of the last input ( test3 )