Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to attribute attack notebooks #2269

Conversation

abigailgold
Copy link
Collaborator

Fix comments in attribute attack notebooks + add example of attacking a numerical feature.

Description

Updated notebooks to reflect latest functionality.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Ran the notebooks.

Test Configuration:

  • OS: MacOS 12.6.8
  • Python version: 3.9

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

… a numerical feature.

Signed-off-by: abigailt <abigailt@il.ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Merging #2269 (9ba2ec3) into dev_1.16.0 (cb4deda) will increase coverage by 3.13%.
Report is 55 commits behind head on dev_1.16.0.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.16.0    #2269      +/-   ##
==============================================
+ Coverage       82.52%   85.66%   +3.13%     
==============================================
  Files             313      313              
  Lines           27782    27810      +28     
  Branches         5082     5086       +4     
==============================================
+ Hits            22927    23823     +896     
+ Misses           3603     2692     -911     
- Partials         1252     1295      +43     

see 20 files with indirect coverage changes

@beat-buesser beat-buesser self-requested a review September 4, 2023 08:24
@beat-buesser beat-buesser self-assigned this Sep 4, 2023
@beat-buesser beat-buesser added the notebooks Notebooks label Sep 4, 2023
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abigailgold Thank you very much for updating the attribute inference attack notebook!

@beat-buesser beat-buesser merged commit 19259d7 into Trusted-AI:dev_1.16.0 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebooks Notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants