Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handlebars to 4.0.8 #143

Closed
cleversprocket opened this issue Nov 30, 2017 · 0 comments · Fixed by #149
Closed

Update handlebars to 4.0.8 #143

cleversprocket opened this issue Nov 30, 2017 · 0 comments · Fixed by #149

Comments

@cleversprocket
Copy link

There’s a bug in handlebars 4.0.6 which prevents using ‘@partial-block’ more than once in a partial. Please update the version to 4.0.8 which fixes it.
jtwebman pushed a commit to jtwebman/express-hbs that referenced this issue Aug 22, 2018
Update dependencies to the latest releases. Fixes issue TryGhost#143.
713b344
@jtwebman jtwebman mentioned this issue Aug 22, 2018
Closed
jtwebman added a commit to jtwebman/express-hbs that referenced this issue Aug 27, 2018
@jtwebman
Fix async render and block cache.
5e28c79 
Fixed TryGhost#144 registerAsyncHelper using the wrong replace call
Fixes TryGhost#143 Update handlebars to 4.0.8 (did latest handlebars)
Fixed TryGhost#101 Cached blocks should be stored per request
Fixed TryGhost#100 Conflict between content blocks
Fixed TryGhost#99 Blocks prone to memory leaks

After digging round most of the weekend I fixed the block and sync cache issues by storing them
on the options which is setup once per request and passed to everything that needed it. This
also fixes the issue with using replace and special strings that can do funny things with
JavaScript replace vs using the function version.

I also update TravisCI to run the newer node versions for tests and update all the dependencies
to the latest versions.
@jtwebman jtwebman mentioned this issue Aug 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix async render and block cache. jtwebman/express-hbs
1 participant
@cleversprocket