Fix async render and block cache. #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed TryGhost#144 registerAsyncHelper using the wrong replace call Fixes TryGhost#143 Update handlebars to 4.0.8 (did latest handlebars) Fixed TryGhost#101 Cached blocks should be stored per request Fixed TryGhost#100 Conflict between content blocks Fixed TryGhost#99 Blocks prone to memory leaks After digging round most of the weekend I fixed the block and sync cache issues by storing them on the options which is setup once per request and passed to everything that needed it. This also fixes the issue with using replace and special strings that can do funny things with JavaScript replace vs using the function version. I also update TravisCI to run the newer node versions for tests and update all the dependencies to the latest versions.
This was referenced Aug 27, 2018
Closed
|
ping @ErisDS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #144 registerAsyncHelper using the wrong replace call
Fixes #143 Update handlebars to 4.0.8 (did latest handlebars)
Fixed #101 Cached blocks should be stored per request
Fixed #100 Conflict between content blocks
Fixed #99 Blocks prone to memory leaks
After digging round most of the weekend I fixed the block and sync cache issues by storing them
on the options which is setup once per request and passed to everything that needed it.
This also fixes the issue with using replace and special strings that can do funny things with
JavaScript replace vs using the function version.
I also update TravisCI to run the newer node versions for tests and update all the dependencies
to the latest versions.