Added hash check, so we can use normal links inside the sidebar tablist #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind of similar to #68 |
| if (L.DomUtil.hasClass(this, 'active')) | ||
| this._sidebar.close(); | ||
| else if (!L.DomUtil.hasClass(this, 'disabled')) | ||
| this._sidebar.open(this.querySelector('a').hash.slice(1)); |
There was a problem hiding this comment.
can you extract the this.querySelector('a').hash into a local variable to avoid the duplicate querySelector() call?
|
@KoenDierckx thanks for the PR! looks quite good to me aside from these two minor issues. |
|
@KoenDierckx sorry for merging #87 before your PR. I must've missed that they targeted the same things. I've found a simpler solution for the JQuery version that I've merged in 3905461. Since both cases handled by this PR are now resolved I'll close it. Feel free to report any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.