Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix for unwrap_left_right_vns #297

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Fix for unwrap_left_right_vns #297

wants to merge 7 commits into from

Conversation

torfjelde
Copy link
Member

I just noticed a bug I introduced in a recent PR when looking at #295 . This PR fixes it. I'll add tests, a sec. @yebai

@torfjelde
Copy link
Member Author

@yebai Can you have a look at this?

yebai
yebai approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yebai
Copy link
Member

yebai commented Jul 30, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 30, 2021
@torfjelde
Fix for unwrap_left_right_vns (#297)
19f9782 
I just noticed a bug I introduced in a recent PR when looking at #295 . This PR fixes it. I'll add tests, a sec. @yebai
@bors
Copy link
Contributor

bors bot commented Jul 30, 2021

Build failed:

@torfjelde
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 30, 2021
@torfjelde
Fix for unwrap_left_right_vns (#297)
fa88dd3 
I just noticed a bug I introduced in a recent PR when looking at #295 . This PR fixes it. I'll add tests, a sec. @yebai
@bors
Copy link
Contributor

bors bot commented Jul 30, 2021

Build failed:

@torfjelde
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 30, 2021
@bors
Try #297:
531bbb3
@bors
Copy link
Contributor

bors bot commented Jul 30, 2021

try

Build succeeded:

@torfjelde
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 30, 2021
@torfjelde
Fix for unwrap_left_right_vns (#297)
99df54b 
I just noticed a bug I introduced in a recent PR when looking at #295 . This PR fixes it. I'll add tests, a sec. @yebai
@bors
Copy link
Contributor

bors bot commented Jul 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Fix for unwrap_left_right_vns [Merged by Bors] - Fix for unwrap_left_right_vns Jul 30, 2021
@bors bors bot closed this Jul 30, 2021
@bors bors bot deleted the torfjelde-patch-1 branch July 30, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torfjelde @yebai