Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions appearing in places where no suggestions should appear #141

Closed
csnover opened this issue Mar 3, 2015 · 11 comments
Closed

Suggestions appearing in places where no suggestions should appear #141

csnover opened this issue Mar 3, 2015 · 11 comments

Comments

@csnover
Copy link
Member

csnover commented Mar 3, 2015

Finish a statement, e.g.

function foo() {
  this.foo;/*1*/
  /*2*/
}

With the cursor at /*1*/ or /*2*/, after having typed the previous ; or \t, suggestions will appear, but should not.

@csnover
Copy link
Member Author

csnover commented Mar 3, 2015

Sorry, accidentally hit Enter in the subject line. Description is there now. 😞

@basarat
Copy link
Member

basarat commented Mar 3, 2015

@csnover can you give me a screenshot? Note: suggestions will appear inside comments. I actually find those helpful. I think they appear from other default providers that come with autocomplete-plus. But to be sure a screenshot at the exact location would help me understand better

@csnover
Copy link
Member Author

csnover commented Mar 3, 2015

screen shot 2015-03-02 at 22 53 37

@basarat
Copy link
Member

basarat commented Mar 3, 2015

@csnover this is intentional. Although not because of our code. Autocomplete+ is now super aggressive (and I think that's a good thing). This is the reason I had to remove commit on enter though : 9c17b73

@csnover
Copy link
Member Author

csnover commented Mar 3, 2015

I can’t think of a reason to tell users all the possible completions like this. I’ve never had an IDE do this without explicit request (i.e. hotkey), because as you noted in that commit it breaks all sorts of things (and it isn’t helpful).

This is not matching normal autocomplete-plus behaviour. Try typing in a JavaScript file and note that autocompletes don’t start until you actually start typing a word, not punctuation.

@csnover
Copy link
Member Author

csnover commented Mar 3, 2015

I suspect this may also be breaking auto-indent, which seems to have stopped working properly at some point within the last couple of weeks.

@basarat
Copy link
Member

basarat commented Mar 3, 2015

I suspect this may also be breaking auto-indent, which seems to have stopped working properly at some point within the last couple of weeks

I've noticed as well. I'd be happy for a fix. Working on better panels right now though.

@basarat
Copy link
Member

basarat commented Mar 6, 2015

I suspect this may also be breaking auto-indent

I think moving to a dynamic code based grammar parsing broke it. Before that it was taken care by us inheriting from .source.js. auto-indent feature will be tracked here : #159

@marlonfan
Copy link

@basarat Me Too!

@vilicvane
Copy link
Contributor

Nice to see it's been marked as high priority.

@basarat
Copy link
Member

basarat commented Apr 28, 2015

I haven't found a better solution than the one I've commited (no autocomplete after ;) so there it is.
released with v4.0.11

@basarat basarat closed this as completed Apr 28, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants